Re: [PATCH v4 1/5] dt-bindings: iio: adc: add xlnx,versal-sysmon binding

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Schema Validation Flaw: Ineffective `minimum` and `maximum` constraints on `reg` arrays.
--

commit 68825d18816914117a9f77e82be41b25ec550f42
Author: Salih Erim <salih.erim@amd.com>

dt-bindings: iio: adc: add xlnx,versal-sysmon binding

Add devicetree binding for the AMD/Xilinx Versal System Monitor (SysMon).
The hardware supports up to 160 supply voltage measurement points and up to
64 temperature satellites. The channels are described as child nodes under
container nodes.

> diff --git a/Documentation/devicetree/bindings/iio/adc/xlnx,versal-sysmon.yaml b/Documentation/devicetree/bindings/iio/adc/xlnx,versal-sysmon.yaml
> new file mode 100644
> index 0000000000000..1ad58e3d61631
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/xlnx,versal-sysmon.yaml

[ ... ]

> +  voltage-channels:
> +    type: object
> +    description:
> +      Container for voltage measurement channels.

[ ... ]

> +    patternProperties:
> +      '^channel@([0-9a-f]|[1-9][0-9a-f])$':
> +        $ref: adc.yaml

[ ... ]

> +        properties:
> +          reg:
> +            minimum: 0
> +            maximum: 159

[Severity: Low]
Because the reg property is evaluated as an array in dt-schema, applying
minimum and maximum directly to it will be silently ignored by the JSON schema
validator. 

Should these constraints be placed under an items array, or can they be
dropped entirely since the patternProperties regex already implicitly restricts
the range?

> +            description:
> +              Voltage measurement register index assigned by the hardware
> +              design tool.
> +
> +        required:
> +          - reg

[ ... ]

> +  temperature-channels:
> +    type: object
> +    description:
> +      Container for temperature satellite measurement channels.

[ ... ]

> +    patternProperties:
> +      '^channel@([1-9a-f]|[1-3][0-9a-f]|40)$':
> +        $ref: adc.yaml

[ ... ]

> +        properties:
> +          reg:
> +            minimum: 1
> +            maximum: 64

[Severity: Low]
Similarly here, are these constraints ineffective because JSON schema ignores
numeric constraints on non-numeric types like the reg array?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260606051707.535281-1-salih.erim@amd.com?part=1