Re: [PATCH v3 1/3] dt-bindings: net: add Realtek r8169 family PCIe Ethernet

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The binding uses `additionalProperties: false` alongside a `$ref` to `ethernet-controller.yaml#`, which incorrectly restricts inherited standard Ethernet properties and forces their manual duplication.
--

commit 766e9c110aa2222534264bb4b3a784c0a71fcff4
Author: Ricardo Pardini <ricardo@pardini.net>

dt-bindings: net: add Realtek r8169 family PCIe Ethernet

Adds a device tree binding for fixed/soldered Realtek PCIe Ethernet controllers
driven by the r8169 driver. The binding supports Open Firmware PCI bus bindings
so board DTs can validate attached properties.

> diff --git a/Documentation/devicetree/bindings/net/realtek,r8169.yaml b/Documentation/devicetree/bindings/net/realtek,r8169.yaml
> new file mode 100644
> index 0000000000000..6923211ff4c93
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/realtek,r8169.yaml

[ ... ]

> +allOf:
> +  - $ref: ethernet-controller.yaml#
> +
> +properties:
> +  compatible:

[ ... ]

> +  reg:
> +    maxItems: 1
> +
> +  local-mac-address: true
> +  mac-address: true
> +  nvmem-cells: true
> +  nvmem-cell-names: true

[Severity: Low]
Is it necessary to redefine these properties manually? Since the binding
already includes a $ref to ethernet-controller.yaml# in the allOf block,
these standard Ethernet properties should be inherited automatically.

> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false

[Severity: Low]
Does using additionalProperties: false here prevent the inheritance of
properties from ethernet-controller.yaml#?

Using unevaluatedProperties: false instead would allow $ref schemas in the
allOf block to be evaluated properly, which would remove the need to
duplicate the mac-address and nvmem-cells properties above.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260605-rk3588-dts-rtl-eth-describe-dt-alias-v3-0-8a8857b39daf@pardini.net?part=1