Re: [PATCH net-next v4 03/16] net: ethernet: oa_tc6: Move oa_tc6.c to its own directory

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [Medium] Module renamed from `oa_tc6` to `oa_tc6_mod` and improper use of `:=` assignment in Makefile.
- [Low] The `F:` pattern in MAINTAINERS does not cover all files in the new directory.
- [Low] The `OA_TC6` Kconfig prompt is now unconditionally visible to all users.
--

commit 5213f15d674af18a29bb38e48f42c89b428013c8
Author: Selvamani Rajagopal <Selvamani.Rajagopal@onsemi.com>

net: ethernet: oa_tc6: Move oa_tc6.c to its own directory

Moving oa_tc6.c to its own directory to facilitate adding more files
to support other features defined by OPEN Alliance 10BASE-T1x Serial
Interface specification.

> diff --git a/MAINTAINERS b/MAINTAINERS
> index eb8cdcc76324f..7e6b28202e88e 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -20001,7 +20001,7 @@ M:	Parthiban Veerasooran <parthiban.veerasooran@microchip.com>
>  L:	netdev@vger.kernel.org
>  S:	Maintained
>  F:	Documentation/networking/oa-tc6-framework.rst
> -F:	drivers/net/ethernet/oa_tc6.c
> +F:	drivers/net/ethernet/oa_tc6/oa_tc6*

[Severity: Low]
Does this pattern leave the new Kconfig and Makefile in this directory
unmaintained? 

Using the directory pattern `drivers/net/ethernet/oa_tc6/` would ensure all
files in the new directory are routed to the OPEN ALLIANCE TC6 FRAMEWORK
maintainers instead of falling back to generic netdev maintainers.

[ ... ]

> diff --git a/drivers/net/ethernet/oa_tc6/Kconfig b/drivers/net/ethernet/oa_tc6/Kconfig
> new file mode 100644
> index 0000000000000..97345f345fb9f
> --- /dev/null
> +++ b/drivers/net/ethernet/oa_tc6/Kconfig
> @@ -0,0 +1,16 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +#
> +# OA TC6 10BASE-T1x MAC-PHY configuration
> +#
> +
> +config OA_TC6
> +	tristate "OPEN Alliance TC6 10BASE-T1x MAC-PHY support"

[Severity: Low]
Is the removal of the `if COMPILE_TEST` condition intentional here?

In the original drivers/net/ethernet/Kconfig, this was conditionally
displayed. Because OA_TC6 is a framework library automatically selected by
dependent hardware drivers, making the prompt unconditionally visible during
kernel configuration might unnecessarily clutter the interface for users.

> +	depends on SPI
> +	select PHYLIB

[ ... ]

> diff --git a/drivers/net/ethernet/oa_tc6/Makefile b/drivers/net/ethernet/oa_tc6/Makefile
> new file mode 100644
> index 0000000000000..f24aae852ef27
> --- /dev/null
> +++ b/drivers/net/ethernet/oa_tc6/Makefile
> @@ -0,0 +1,7 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +#
> +# Makefile for OA TC6 10BASE-T1x MAC-PHY
> +#
> +
> +obj-$(CONFIG_OA_TC6) := oa_tc6_mod.o
> +oa_tc6_mod-objs := oa_tc6.o

[Severity: Medium]
Does this change the resulting kernel module name from oa_tc6.ko to
oa_tc6_mod.ko?

Renaming a kernel module breaks ABI and userspace tools that expect the old
module name. A standard Kbuild practice when converting a single-file module
to a multi-file module is to rename the original C file (e.g., to
oa_tc6_main.c) and use `obj-$(CONFIG_OA_TC6) += oa_tc6.o` with
`oa_tc6-y := oa_tc6_main.o`.

Also, does using `:=` instead of `+=` here overwrite the `obj-` variable
instead of correctly appending to it?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260605-s2500-mac-phy-support-v4-0-de0fbc13c6d8@onsemi.com?part=3