Re: [PATCH net-next v4 15/16] dt-bindings: net: add onsemi's S2500

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The Device Tree binding and example encode a temporary software workaround for an interrupt trigger type instead of describing the actual hardware specification.
--

commit 4625f72902becee75fd7fad94c017813fc2d4435
Author: Selvamani Rajagopal <Selvamani.Rajagopal@onsemi.com>

dt-bindings: net: add onsemi's S2500

This commit adds the YAML device tree binding for the onsemi S2500 IEEE
802.3cg Ethernet transceiver device. It specifies IRQ triggers based on
current framework limitations rather than the hardware specification.

> diff --git a/Documentation/devicetree/bindings/net/onnn,s2500.yaml b/Documentation/devicetree/bindings/net/onnn,s2500.yaml
> new file mode 100644
> index 0000000000000..11edf10508d9f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/onnn,s2500.yaml
[ ... ]
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    spi {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      ethernet@0 {
> +        compatible = "onnn,s2500";
> +        reg = <0>;
> +        pinctrl-names = "default";
> +        pinctrl-0 = <&eth0_pins>;
> +        interrupt-parent = <&gpio>;
> +        interrupts = <25 IRQ_TYPE_EDGE_FALLING>;

[Severity: Medium]
Device trees are meant to be OS-agnostic hardware descriptions. Since the
commit message notes the OPEN Alliance specification calls for a level-low
interrupt, does it make sense to encode a temporary OS software workaround
(IRQ_TYPE_EDGE_FALLING) into the stable binding example?

Could the binding and example accurately reflect the hardware using
IRQ_TYPE_LEVEL_LOW, and the temporary workaround be confined to the driver
or framework code instead?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260605-s2500-mac-phy-support-v4-0-de0fbc13c6d8@onsemi.com?part=15