Re: [PATCH 2/3] mfd: 88pm886: Initialize battery page

[Lee Jones <lee@kernel.org>]

On Sun, 07 Jun 2026, Duje Mihanović wrote:

> On Sunday, 7 June 2026 12:19:21 Central European Summer Time Karel Balej 
> wrote:
> > Duje Mihanović, 2026-05-26T21:14:48+02:00:
> 
> [...]
> 
> > > @@ -88,7 +94,8 @@ static int pm886_probe(struct i2c_client *client)
> > > 
> > >  	struct regmap_irq_chip_data *irq_data;
> > >  	struct device *dev = &client->dev;
> > >  	struct pm886_chip *chip;
> > > 
> > > -	struct regmap *regmap;
> > > +	struct regmap *regmap, *regmap_battery;
> > > +	struct i2c_client *battery_page;
> > 
> > Not sure if this should be reordered to preserve the "reverse Christmas
> > tree", but maybe it's fine if checkpatch didn't complain.
> 
> I opted not to move the declarations around in this case as IMO it would 
> present noise in the diff, but on second thought it may have been the better 
> choice.
> 
> Lee, do you by chance know how to proceed here?

You can move them.

Please take into consideration data-size as well, rather than blindly
following RCT.  Larger items (structs) at the top down to smaller (ints
and bools) as the bottom.  Luckily the larger (data size) items also end
up being longer (string).

-- 
Lee Jones