[PATCH] spi: dt-bindings: octeon: Convert to DT schema

[PATCH] spi: dt-bindings: octeon: Convert to DT schema

[Ninad Naik]

Convert octeon-3010 to DT schema

Signed-off-by: Ninad Naik <ninadnaik07@gmail.com>
---
 .../bindings/spi/cavium,octeon-3010-spi.yaml  | 67 +++++++++++++++++++
 .../devicetree/bindings/spi/spi-octeon.txt    | 33 ---------
 2 files changed, 67 insertions(+), 33 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/spi/cavium,octeon-3010-spi.yaml
 delete mode 100644 Documentation/devicetree/bindings/spi/spi-octeon.txt

diff --git a/Documentation/devicetree/bindings/spi/cavium,octeon-3010-spi.yaml b/Documentation/devicetree/bindings/spi/cavium,octeon-3010-spi.yaml
new file mode 100644
index 000000000000..3dbbb4f3c104
--- /dev/null
+++ b/Documentation/devicetree/bindings/spi/cavium,octeon-3010-spi.yaml
@@ -0,0 +1,67 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/spi/cavium,octeon-3010-spi.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Cavium, Inc. OCTEON SoC SPI master controller
+
+description:
+  The Cavium OCTEON SPI controller is an SPI master controller found in
+  OCTEON SoCs.
+
+maintainers:
+  - Mark Brown <broonie@kernel.org>
+
+allOf:
+  - $ref: spi-controller.yaml#
+
+properties:
+  compatible:
+    const: cavium,octeon-3010-spi
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+  - interrupts
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    / {
+        #address-cells = <2>;
+        #size-cells = <2>;
+
+        intc: interrupt-controller {
+            interrupt-controller;
+            #interrupt-cells = <2>;
+        };
+
+        spi@1070000001000 {
+            compatible = "cavium,octeon-3010-spi";
+            reg = <0x10700 0x00001000 0x0 0x100>;
+            interrupt-parent = <&intc>;
+            interrupts = <0 58>;
+            #address-cells = <1>;
+            #size-cells = <0>;
+
+            eeprom@0 {
+                compatible = "st,m95256", "atmel,at25";
+                reg = <0>;
+                spi-max-frequency = <5000000>;
+                spi-cpha;
+                spi-cpol;
+                pagesize = <64>;
+                size = <32768>;
+                address-width = <16>;
+            };
+        };
+    };
+...
diff --git a/Documentation/devicetree/bindings/spi/spi-octeon.txt b/Documentation/devicetree/bindings/spi/spi-octeon.txt
deleted file mode 100644
index 431add192342..000000000000
--- a/Documentation/devicetree/bindings/spi/spi-octeon.txt
+++ /dev/null
@@ -1,33 +0,0 @@
-Cavium, Inc. OCTEON SOC SPI master controller.
-
-Required properties:
-- compatible : "cavium,octeon-3010-spi"
-- reg : The register base for the controller.
-- interrupts : One interrupt, used by the controller.
-- #address-cells : <1>, as required by generic SPI binding.
-- #size-cells : <0>, also as required by generic SPI binding.
-
-Child nodes as per the generic SPI binding.
-
-Example:
-
-	spi@1070000001000 {
-		compatible = "cavium,octeon-3010-spi";
-		reg = <0x10700 0x00001000 0x0 0x100>;
-		interrupts = <0 58>;
-		#address-cells = <1>;
-		#size-cells = <0>;
-
-		eeprom@0 {
-			compatible = "st,m95256", "atmel,at25";
-			reg = <0>;
-			spi-max-frequency = <5000000>;
-			spi-cpha;
-			spi-cpol;
-
-			pagesize = <64>;
-			size = <32768>;
-			address-width = <16>;
-		};
-	};
-
-- 
2.54.0

Re: [PATCH] spi: dt-bindings: octeon: Convert to DT schema

[Rob Herring (Arm)]

On Sun, 07 Jun 2026 19:53:56 +0530, Ninad Naik wrote:
> Convert octeon-3010 to DT schema
> 
> Signed-off-by: Ninad Naik <ninadnaik07@gmail.com>
> ---
>  .../bindings/spi/cavium,octeon-3010-spi.yaml  | 67 +++++++++++++++++++
>  .../devicetree/bindings/spi/spi-octeon.txt    | 33 ---------
>  2 files changed, 67 insertions(+), 33 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/spi/cavium,octeon-3010-spi.yaml
>  delete mode 100644 Documentation/devicetree/bindings/spi/spi-octeon.txt
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/spi/cavium,octeon-3010-spi.example.dtb: /: 'compatible' is a required property
	from schema $id: http://devicetree.org/schemas/root-node.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/spi/cavium,octeon-3010-spi.example.dtb: /: 'model' is a required property
	from schema $id: http://devicetree.org/schemas/root-node.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.kernel.org/project/devicetree/patch/20260607142356.2844008-1-ninadnaik07@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.

Re: [PATCH] spi: dt-bindings: octeon: Convert to DT schema

[Rob Herring]

On Sun, Jun 07, 2026 at 07:53:56PM +0530, Ninad Naik wrote:
> Convert octeon-3010 to DT schema
> 
> Signed-off-by: Ninad Naik <ninadnaik07@gmail.com>
> ---
>  .../bindings/spi/cavium,octeon-3010-spi.yaml  | 67 +++++++++++++++++++
>  .../devicetree/bindings/spi/spi-octeon.txt    | 33 ---------
>  2 files changed, 67 insertions(+), 33 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/spi/cavium,octeon-3010-spi.yaml
>  delete mode 100644 Documentation/devicetree/bindings/spi/spi-octeon.txt
> 
> diff --git a/Documentation/devicetree/bindings/spi/cavium,octeon-3010-spi.yaml b/Documentation/devicetree/bindings/spi/cavium,octeon-3010-spi.yaml
> new file mode 100644
> index 000000000000..3dbbb4f3c104
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/spi/cavium,octeon-3010-spi.yaml
> @@ -0,0 +1,67 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/spi/cavium,octeon-3010-spi.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Cavium, Inc. OCTEON SoC SPI master controller
> +
> +description:
> +  The Cavium OCTEON SPI controller is an SPI master controller found in
> +  OCTEON SoCs.
> +
> +maintainers:
> +  - Mark Brown <broonie@kernel.org>

This should be someone with this h/w. But there doesn't appear to be any 
OCTEON maintainer. There isn't any .dts using the compatible either. 
Perhaps this driver and binding can just be removed?

> +  compatible:
> +    const: cavium,octeon-3010-spi


> +examples:
> +  - |
> +    / {

Drop. You don't need the root node.

> +        #address-cells = <2>;
> +        #size-cells = <2>;
> +
> +        intc: interrupt-controller {
> +            interrupt-controller;
> +            #interrupt-cells = <2>;
> +        };

Drop. Examples don't need providers.

Rob

Re: [PATCH] spi: dt-bindings: octeon: Convert to DT schema

[Rob Herring]

On Mon, Jun 08, 2026 at 09:32:59AM -0500, Rob Herring wrote:
> On Sun, Jun 07, 2026 at 07:53:56PM +0530, Ninad Naik wrote:
> > Convert octeon-3010 to DT schema
> > 
> > Signed-off-by: Ninad Naik <ninadnaik07@gmail.com>
> > ---
> >  .../bindings/spi/cavium,octeon-3010-spi.yaml  | 67 +++++++++++++++++++
> >  .../devicetree/bindings/spi/spi-octeon.txt    | 33 ---------
> >  2 files changed, 67 insertions(+), 33 deletions(-)
> >  create mode 100644 Documentation/devicetree/bindings/spi/cavium,octeon-3010-spi.yaml
> >  delete mode 100644 Documentation/devicetree/bindings/spi/spi-octeon.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/spi/cavium,octeon-3010-spi.yaml b/Documentation/devicetree/bindings/spi/cavium,octeon-3010-spi.yaml
> > new file mode 100644
> > index 000000000000..3dbbb4f3c104
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/spi/cavium,octeon-3010-spi.yaml
> > @@ -0,0 +1,67 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/spi/cavium,octeon-3010-spi.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Cavium, Inc. OCTEON SoC SPI master controller
> > +
> > +description:
> > +  The Cavium OCTEON SPI controller is an SPI master controller found in
> > +  OCTEON SoCs.
> > +
> > +maintainers:
> > +  - Mark Brown <broonie@kernel.org>
> 
> This should be someone with this h/w. But there doesn't appear to be any 
> OCTEON maintainer. There isn't any .dts using the compatible either. 
> Perhaps this driver and binding can just be removed?

Maybe not. Seems this is used on newer Octeon platforms like cn7130 
which aren't that old. Some Ubiquiti devices use it and run 5.4 kernel 
with OpenWRT:

https://openwrt.org/toh/ubiquiti/edgerouter_4

Rob