Re: [PATCH v5 4/4] arm64: dts: renesas: r9a09g047e57-smarc: add DA7212 audio codec support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [Medium] Uninitialized `i2c1` interface and missing pin multiplexing configuration.
- [Low] Missing labels `audio_clkb` and `audio_clkc` resulting in device tree build error and incorrect clock configuration.
- [Low] Unnecessary `#address-cells` and `#size-cells` properties in the `codec@1a` node.
--

commit fe54753481ec78b59331c5d3dffff0a3ac46ac08
Author: John Madieu <john.madieu.xa@bp.renesas.com>

arm64: dts: renesas: r9a09g047e57-smarc: add DA7212 audio codec support

This patch enables audio support on the RZ/G3E SMARC EVK board. It configures
a DA7212 audio codec on I2C1 and the SSI interfaces for playback and capture.

> diff --git a/arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts b/arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts
> index 6372f582a7c41..7defd342294ad 100644
> --- a/arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts
> +++ b/arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts

[ ... ]

> @@ -55,6 +86,22 @@ vqmmc_sd1_pvdd: regulator-vqmmc-sd1-pvdd {
>  		gpios-states = <0>;
>  		states = <3300000 0>, <1800000 1>;
>  	};
> +
> +	sound_card: sound {
> +		compatible = "audio-graph-card";
> +
> +		label = "snd-rzg3e";
> +
> +		dais = <&rsnd_port0>;	/* DA7212 */
> +	};
> +};
> +
> +&audio_clkb {
> +	clock-frequency = <11289600>;
> +};
> +
> +&audio_clkc {
> +	clock-frequency = <12288000>;
>  };

[Severity: Low]
Will this cause a dtc compilation error? The labels audio_clkb and audio_clkc
do not appear to be defined in the included SoC device trees.

Additionally, should these be configured as external fixed clocks? Since they
are internal CPG module clocks, it might be more appropriate to configure
their frequencies using assigned-clocks and assigned-clock-rates inside the
snd_rzg3e node.

[ ... ]

> @@ -99,6 +146,37 @@ &i2c0 {
>  	pinctrl-names = "default";
>  };
>  
> +&i2c1 {

[Severity: Medium]
Is this missing the status = "okay" and pinctrl-0 properties? Without these,
the I2C controller remains disabled by default, which may prevent the audio
codec from initializing and cause the sound card binding to fail.

> +	da7212: codec@1a {
> +		compatible = "dlg,da7212";
> +		#sound-dai-cells = <0>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;

[Severity: Low]
Are the #address-cells and #size-cells properties necessary here? Since the
only child node is a port without a unit address or a reg property, this
could trigger an avoid_unnecessary_addr_size dtc schema warning.

> +		reg = <0x1a>;
> +
> +		clocks = <&versa3 1>;
> +		clock-names = "mclk";

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260610074702.1743334-1-john.madieu.xa@bp.renesas.com?part=4