Re: [PATCH v2 2/2] arm64: dts: rockchip: Add HINLINK H28K

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly added device tree `rk3528-hinlink-h28k.dts` fails to compile because it references undefined USB node labels.
--

commit 07ca37acc11522d114428bc076a631a2223bfa47
Author: Chukun Pan <amadeus@jmu.edu.cn>
Subject: arm64: dts: rockchip: Add HINLINK H28K

This commit introduces a new device tree for the HINLINK H28K (LinkStar
H28K) single-board computer based on the Rockchip RK3528 SoC. It adds
support for basic features including Ethernet, eMMC, MicroSD, and USB.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3528-hinlink-h28k.dts b/arch/arm64/boot/dts/rockchip/rk3528-hinlink-h28k.dts
> new file mode 100644
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3528-hinlink-h28k.dts

[ ... ]

> +&uart0 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&uart0m0_xfer>;
> +	status = "okay";
> +};
> +
> +&usb2phy {
> +	status = "okay";
> +};
> +
> +&usb2phy_host {
> +	phy-supply = <&vcc5v0_sys>;
> +	status = "okay";
> +};
> +
> +&usb_host0_ehci {
> +	status = "okay";
> +};
> +
> +&usb_host0_ohci {
> +	status = "okay";
> +};

[Severity: Low]
Are these USB node labels defined in the included rk3528.dtsi at this
revision? It appears that referencing &usb2phy, &usb2phy_host,
&usb_host0_ehci, and &usb_host0_ohci here will cause a DTC build failure
with a "Label or path not found" error because the underlying node labels
do not seem to exist yet in the included trees.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260610100006.366963-1-amadeus@jmu.edu.cn?part=2