[PATCH v2 0/2] Add PCIe binding for IPQ9650 and IPQ5210

[PATCH v2 0/2] Add PCIe binding for IPQ9650 and IPQ5210

[Kathiravan Thirumoorthy]

Add the IPQ9650 and IPQ5210 PCIe compatible to the IPQ9574 binding, as the
IPQ9650 and IPQ5210 controller is compatible with IPQ9574 and uses it as
the fallback.

Make the global interrupt is required for these SoCs.

Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
---
Changes in v2:
- Made the global interrupt as required
- Incorporated the IPQ5210 binding change into this series to avoid
  conflicts
- Link to v1: https://patch.msgid.link/20260602-ipq9650_pcie_binding-v1-1-486a535da8c5@oss.qualcomm.com

To: Bjorn Helgaas <bhelgaas@google.com>
To: Lorenzo Pieralisi <lpieralisi@kernel.org>
To: Krzysztof Wilczyński <kwilczynski@kernel.org>
To: Manivannan Sadhasivam <mani@kernel.org>
To: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzk+dt@kernel.org>
To: Conor Dooley <conor+dt@kernel.org>
To: Bjorn Andersson <andersson@kernel.org>
Cc: linux-arm-msm@vger.kernel.org
Cc: linux-pci@vger.kernel.org
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org

---
Kathiravan Thirumoorthy (1):
      dt-bindings: PCI: qcom,pcie-ipq9574: Add IPQ9650 compatible

Varadarajan Narayanan (1):
      dt-bindings: PCI: qcom,pcie-ipq9574: Document the ipq5210 pcie controller

 .../devicetree/bindings/pci/qcom,pcie-ipq9574.yaml        | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
---
base-commit: 49e02880ec0a8c378e811bc9d85da188d7c6204c
change-id: 20260521-ipq9650_pcie_binding-1c76095954d9

Best regards,
--  
Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>

[PATCH v2 1/2] dt-bindings: PCI: qcom,pcie-ipq9574: Add IPQ9650 compatible

[Kathiravan Thirumoorthy]

Add the IPQ9650 PCIe compatible to the IPQ9574 binding, as the IPQ9650
controller is compatible with IPQ9574 and uses it as the fallback.

While at it, make the global interrupt as required for IPQ9650.

Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
---
 .../devicetree/bindings/pci/qcom,pcie-ipq9574.yaml          | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-ipq9574.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-ipq9574.yaml
index 4be342cc04e1..e92acddb969e 100644
--- a/Documentation/devicetree/bindings/pci/qcom,pcie-ipq9574.yaml
+++ b/Documentation/devicetree/bindings/pci/qcom,pcie-ipq9574.yaml
@@ -19,6 +19,7 @@ properties:
           - enum:
               - qcom,pcie-ipq5332
               - qcom,pcie-ipq5424
+              - qcom,pcie-ipq9650
           - const: qcom,pcie-ipq9574
 
   reg:
@@ -82,6 +83,18 @@ required:
 
 allOf:
   - $ref: qcom,pcie-common.yaml#
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - qcom,pcie-ipq9650
+    then:
+      properties:
+        interrupts:
+          minItems: 9
+        interrupt-names:
+          minItems: 9
 
 unevaluatedProperties: false
 

-- 
2.34.1

Re: [PATCH v2 1/2] dt-bindings: PCI: qcom,pcie-ipq9574: Add IPQ9650 compatible

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The schema modification fails to make the global interrupt mandatory for IPQ9650 when `msi-map` is used.
--

commit 27378ca447659c2b32e287fcda248ae3808316af
Author: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>

dt-bindings: PCI: qcom,pcie-ipq9574: Add IPQ9650 compatible

This commit adds the IPQ9650 PCIe compatible string to the IPQ9574 binding
and updates the constraints to make the global interrupt required for the
IPQ9650 controller.

> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-ipq9574.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-ipq9574.yaml
> --- a/Documentation/devicetree/bindings/pci/qcom,pcie-ipq9574.yaml
> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-ipq9574.yaml
[ ... ]
> @@ -82,6 +83,18 @@ required:
>  
>  allOf:
>    - $ref: qcom,pcie-common.yaml#
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - qcom,pcie-ipq9650
> +    then:
> +      properties:
> +        interrupts:
> +          minItems: 9
> +        interrupt-names:
> +          minItems: 9

[Severity: Medium]
The commit message mentions making the global interrupt required for IPQ9650,
but does this block actually enforce its presence?

Since qcom,pcie-common.yaml allows interrupts and interrupt-names to be
omitted entirely if an msi-map property is present, a node could omit
the interrupts property completely. If omitted, the minItems constraints
here are skipped, and the node will silently pass validation without
providing the global interrupt.

Should interrupts and interrupt-names also be explicitly added to a
required list within this then block to ensure they cannot be bypassed?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260610-ipq9650_pcie_binding-v2-0-69e27a1fbf1c@oss.qualcomm.com?part=1

[PATCH v2 2/2] dt-bindings: PCI: qcom,pcie-ipq9574: Document the ipq5210 pcie controller

[Kathiravan Thirumoorthy]

From: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>

Document the ipq5210 PCIe controller using ipq9574 as fallback compatible.

Signed-off-by: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>
Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
---
 Documentation/devicetree/bindings/pci/qcom,pcie-ipq9574.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-ipq9574.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-ipq9574.yaml
index e92acddb969e..533079811881 100644
--- a/Documentation/devicetree/bindings/pci/qcom,pcie-ipq9574.yaml
+++ b/Documentation/devicetree/bindings/pci/qcom,pcie-ipq9574.yaml
@@ -17,6 +17,7 @@ properties:
           - qcom,pcie-ipq9574
       - items:
           - enum:
+              - qcom,pcie-ipq5210
               - qcom,pcie-ipq5332
               - qcom,pcie-ipq5424
               - qcom,pcie-ipq9650
@@ -88,6 +89,7 @@ allOf:
         compatible:
           contains:
             enum:
+              - qcom,pcie-ipq5210
               - qcom,pcie-ipq9650
     then:
       properties:

-- 
2.34.1