* Re: [PATCH] dt-bindings: pinctrl: qcom,pmic-gpio: Add Qualcomm PMK7750
2026-06-10 12:40 [PATCH] dt-bindings: pinctrl: qcom,pmic-gpio: Add Qualcomm PMK7750 Krzysztof Kozlowski
@ 2026-06-10 12:53 ` sashiko-bot
0 siblings, 0 replies; 2+ messages in thread
From: sashiko-bot @ 2026-06-10 12:53 UTC (permalink / raw)
To: Krzysztof Kozlowski; +Cc: robh, conor+dt, devicetree
Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [High] The new `qcom,pmk7750-gpio` compatible string is missing from the C driver's OF match table, and the binding schema prevents using a functional fallback, making the hardware impossible to probe.
- [Medium] The top-level MFD binding for `qcom,pmk7750` is missing, preventing full device tree node validation for the new PMIC.
- [Low] The newly added compatible string 'qcom,pmk7750-gpio' violates alphabetical sorting in the enum and documentation lists.
--
commit a637ed7ee2349c673140cc49df5a55b91d3fa732
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
dt-bindings: pinctrl: qcom,pmic-gpio: Add Qualcomm PMK7750
This commit documents the Qualcomm PMK7750 PMIC GPIO controller, noting
it is almost the same as the PMK8550. It updates the qcom,pmic-gpio
schema to include the new compatible string.
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
> @@ -71,6 +71,7 @@ properties:
> - qcom,pmih0108-gpio
> - qcom,pmiv0104-gpio
> - qcom,pmk8350-gpio
> + - qcom,pmk7750-gpio
[Severity: Low]
Should these compatible strings remain alphabetically sorted? It looks like
qcom,pmk7750-gpio is inserted after qcom,pmk8350-gpio here.
[Severity: High]
The commit message mentions this hardware is compatible with PMK8550.
However, the schema restricts the secondary fallback compatible string
to exactly qcom,spmi-gpio or qcom,ssbi-gpio, preventing the use of
qcom,pmk8550-gpio as a fallback:
- enum:
- qcom,spmi-gpio
- qcom,ssbi-gpio
Because the driver in drivers/pinctrl/qcom/pinctrl-spmi-gpio.c requires an
exact match on the primary string and does not generically match
qcom,spmi-gpio:
static const struct of_device_id pmic_gpio_of_match[] = {
...
{ .compatible = "qcom,pmk8350-gpio", .data = (void *) 4 },
{ .compatible = "qcom,pmk8550-gpio", .data = (void *) 6 },
...
will this device be prevented from probing? The qcom,pmk7750-gpio string
was not added to the driver's match table, and the schema restricts using
functional fallbacks.
[ ... ]
> @@ -501,6 +503,7 @@ $defs:
> - gpio1-gpio10 for pmi8994
> - gpio1-gpio18 for pmih0108
> - gpio1-gpio4 for pmk8350
> + - gpio1-gpio6 for pmk7750
[Severity: Low]
Is there an expectation to keep this documentation list alphabetically sorted
as well?
[Severity: Medium]
Since a new PMIC GPIO block is being added, is there also a need to document
the top-level MFD in Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml?
Without it, device tree nodes declaring the top-level qcom,pmk7750 PMIC might
trigger validation errors.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260610124048.253162-2-krzysztof.kozlowski@oss.qualcomm.com?part=1
^ permalink raw reply [flat|nested] 2+ messages in thread