Re: [PATCH V11 7/9] iio: imu: inv_icm42607: Add Accelerometer for icm42607

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing `iio_device_claim_direct()` protection when changing the sampling frequency (ODR) in `inv_icm42607_accel_write_raw()`.
--

commit 09acc28167411b3db95fd7b8d7918637d445b62b
Author: Chris Morgan <macromorgan@hotmail.com>

iio: imu: inv_icm42607: Add Accelerometer for icm42607

This commit adds support for the accelerometer sensor to the icm42607
driver.

> diff --git a/drivers/iio/imu/inv_icm42607/inv_icm42607_accel.c b/drivers/iio/imu/inv_icm42607/inv_icm42607_accel.c
> new file mode 100644
> --- /dev/null
> +++ b/drivers/iio/imu/inv_icm42607/inv_icm42607_accel.c

[ ... ]

> +static int inv_icm42607_accel_write_raw(struct iio_dev *indio_dev,
> +					struct iio_chan_spec const *chan,
> +					int val, int val2, long mask)
> +{
> +	int ret;
> +
> +	if (chan->type != IIO_ACCEL)
> +		return -EINVAL;
> +
> +	switch (mask) {
> +	case IIO_CHAN_INFO_SCALE:
> +		if (!iio_device_claim_direct(indio_dev))
> +			return -EBUSY;
> +		ret = inv_icm42607_accel_write_scale(indio_dev, val, val2);
> +		iio_device_release_direct(indio_dev);
> +		return ret;
> +	case IIO_CHAN_INFO_SAMP_FREQ:
> +		return inv_icm42607_accel_write_odr(indio_dev, val, val2);

[Severity: Medium]
Should this IIO_CHAN_INFO_SAMP_FREQ case be protected by
iio_device_claim_direct() and iio_device_release_direct() similar to the
IIO_CHAN_INFO_SCALE case above it?

While the driver currently only supports INDIO_DIRECT_MODE, omitting the lock
here leaves the state management inconsistent. If buffered mode is added in
the future, modifying the sampling frequency while the buffer is actively
streaming could lead to stream breakage or corrupted timestamps.

> +	default:
> +		return -EINVAL;
> +	}
> +}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260610175455.19006-1-macroalpha82@gmail.com?part=7