Re: [PATCH V11 6/9] iio: imu: inv_icm42607: Add Temp Support in icm42607

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The temperature sensor is permanently enabled after the first read, causing continuous power drain, preventing low-power accelerometer clocks, and forcing unnecessary startup delays on subsequent sensor reads.
--

commit 910deb05735ec6ed5869092361616349ba5cc0f7
Author: Chris Morgan <macromorgan@hotmail.com>

iio: imu: inv_icm42607: Add Temp Support in icm42607

Add functions for reading temperature sensor data.

> diff --git a/drivers/iio/imu/inv_icm42607/inv_icm42607_temp.c b/drivers/iio/imu/inv_icm42607/inv_icm42607_temp.c
> new file mode 100644
> index 0000000000000..55260082a19ed
> --- /dev/null
> +++ b/drivers/iio/imu/inv_icm42607/inv_icm42607_temp.c

[ ... ]

> +static int inv_icm42607_temp_read(struct inv_icm42607_state *st, s16 *temp)
> +{
> +	struct device *dev = regmap_get_device(st->map);
> +	__be16 *raw;
> +	int ret;
> +
> +	PM_RUNTIME_ACQUIRE_AUTOSUSPEND(dev, pm);
> +	ret = PM_RUNTIME_ACQUIRE_ERR(&pm);
> +	if (ret)
> +		return ret;
> +
> +	guard(mutex)(&st->lock);
> +
> +	ret = inv_icm42607_set_temp_conf(st, true, NULL);
> +	if (ret)
> +		return ret;
> +
> +	raw = &st->buffer[0];
> +	ret = regmap_bulk_read(st->map, INV_ICM42607_REG_TEMP_DATA1,
> +			       raw, sizeof(*raw));
> +	if (ret)
> +		return ret;
> +
> +	*temp = be16_to_cpup(raw);
> +	if (*temp == INV_ICM42607_DATA_INVALID)
> +		return -EINVAL;
> +
> +	return 0;
> +}

[Severity: Medium]
Does this leave the temperature sensor permanently enabled?

Looking at inv_icm42607_temp_read(), the sensor is enabled with
inv_icm42607_set_temp_conf(st, true, NULL) but is never disabled before the
function returns on either the success or error paths.

Because st->conf.temp_en remains true, it seems this would prevent the
setting of the INV_ICM42607_PWR_MGMT0_ACCEL_LP_CLK_SEL bit in
inv_icm42607_set_pwr_mgmt0(), permanently disabling the accelerometer
low-power clock.

Would this also force a 77ms startup delay on every subsequent pm_runtime
resume?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260610175455.19006-1-macroalpha82@gmail.com?part=6