Devicetree
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Md Shofiqul Islam <shofiqtest@gmail.com>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
	robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	krzk@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: iio: accel: Convert lis302 binding to YAML schema
Date: Thu, 11 Jun 2026 18:09:18 +0100	[thread overview]
Message-ID: <20260611-spoken-prewar-b5a4b94787cd@spud> (raw)
In-Reply-To: <20260611140640.4b144bc2@jic23-huawei>

[-- Attachment #1: Type: text/plain, Size: 3637 bytes --]

On Thu, Jun 11, 2026 at 02:06:40PM +0100, Jonathan Cameron wrote:
> On Wed, 10 Jun 2026 17:40:04 +0100
> Conor Dooley <conor@kernel.org> wrote:
> 
> > On Wed, Jun 10, 2026 at 04:56:40PM +0100, Jonathan Cameron wrote:
> > > On Wed, 10 Jun 2026 14:00:51 +0300
> > > Md Shofiqul Islam <shofiqtest@gmail.com> wrote:
> > >   
> > > > Convert the STMicroelectronics LIS302DL/LIS3LV02D accelerometer device
> > > > tree binding from plain text format to YAML schema format.
> > > > 
> > > > The binding covers two variants matched via their respective bus drivers:
> > > > - SPI: st,lis302dl-spi (drivers/misc/lis3lv02d/lis3lv02d_spi.c)
> > > > - I2C: st,lis3lv02d   (drivers/misc/lis3lv02d/lis3lv02d_i2c.c)
> > > > 
> > > > Document all vendor-specific properties read by the driver via
> > > > of_property_read_*(), including click detection, IRQ routing, free-fall/
> > > > wake-up engines, high-pass filtering, axis remapping, output data rate,
> > > > and self-test limits.
> > > > 
> > > > Also correct the click threshold property names: the driver reads
> > > > "st,click-threshold-{x,y,z}" but the old .txt documented them as
> > > > "st,click-thresh-{x,y,z}".
> > > > 
> > > > Validated with: make dt_binding_check   DT_SCHEMA_FILES=Documentation/devicetree/bindings/iio/accel/st,lis302dl.yaml
> > > > 
> > > > Signed-off-by: Md Shofiqul Islam <shofiqtest@gmail.com>  
> > > 
> > > Hi.
> > > 
> > > So the conundrum here is whether we want to keep carrying this binding
> > > as it dates to a previous era.
> > > 
> > > The driver never made it to IIO and is still in drivers/misc.
> > > The majority of what is the text document should never have been
> > > in DT in the first place. I'll guess this dates all the way back
> > > to the wild west days before we had regular binding review.  
> > 
> > I'd say this should be treated like a staging binding but for the fact
> > that this has a user in arm. Problem of course is that it's probably
> > impossible to get that board and so doing any rework is probably not
> > realistic for this submitter?
> > Is there a general policy for iio devices in misc? Do they get reworked
> > to be moved?
> 
> It is tricky if we have upstream users because the ABI will change on them.
> 
> I'm not sure how easy this would be to add to the existing st sensors driver
> as these are very early parts.  If we could maybe we'd do so and just deal
> with the mess of having to disable one or other driver. 
> 
> My gut feeling here is ancient part, let it get dropped in a year or
> two and not worry about adding support to a standard IIO driver unless
> anyone actually has hardware and wants to do it.
> 
> > 
> > The user funnily enough has the binding's click-thresh properties:
> > 		st,click-single-x;
> > 		st,click-single-y;
> > 		st,click-single-z;
> > 		st,click-thresh-x = <10>;
> > 		st,click-thresh-y = <10>;
> > 		st,click-thresh-z = <10>;
> > 		st,irq1-click;
> > 		st,irq2-click;
> > 		st,wakeup-x-lo;
> > 		st,wakeup-x-hi;
> > 		st,wakeup-y-lo;
> > 		st,wakeup-y-hi;
> > 		st,wakeup-z-lo;
> > 		st,wakeup-z-hi;
> > Dunno what that ultimately means in terms of which should be used
> > though.
> Set those as defaults in the driver if all upstream users have those
> values and then drop reading them from dt?

Actually, there's more than one user in arm, but there's a mix of
compatibles and properties used. Probably not really viable unless these
are all unique compatible + property combinations. FWIW, there's more
compatibles used than those documented, that fall back to the documented
ones.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2026-06-11 17:09 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-10 11:00 [PATCH] dt-bindings: iio: accel: Convert lis302 binding to YAML schema Md Shofiqul Islam
2026-06-10 11:16 ` sashiko-bot
2026-06-10 15:56 ` Jonathan Cameron
2026-06-10 16:40   ` Conor Dooley
2026-06-11 13:06     ` Jonathan Cameron
2026-06-11 17:09       ` Conor Dooley [this message]
2026-06-11 17:48         ` Rob Herring
2026-06-10 19:23   ` Rob Herring
2026-06-11 13:07     ` Jonathan Cameron
2026-06-10 19:20 ` Rob Herring
2026-06-11  0:33 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260611-spoken-prewar-b5a4b94787cd@spud \
    --to=conor@kernel.org \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    --cc=shofiqtest@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox