* [PATCH v3] dt-bindings: interrupt-controller: ti,irq-crossbar: Convert to DT schema
@ 2026-06-11 21:12 Bhargav Joshi
2026-06-15 21:01 ` Rob Herring (Arm)
0 siblings, 1 reply; 5+ messages in thread
From: Bhargav Joshi @ 2026-06-11 21:12 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Thomas Gleixner,
Sricharan R
Cc: devicetree, linux-kernel, goledhruva, m-chawdhry, daniel.baluta,
simona.toaca, j.bhargav.u
Convert TI irq-crossbar binding from text format to DT schema.
As part of conversion following changes are made:
- Add '#interrupt-cells' as a required property which was missing in
text binding
- As irq-crossbar is interrupt-controller. Move binding from
bindings/arm/omap to bindings/interrupt-controller
Signed-off-by: Bhargav Joshi <j.bhargav.u@gmail.com>
---
Changes in v3:
- Fixed typo in property description
- Link to v2: https://lore.kernel.org/r/20260611-crossbar-v2-1-231d4f88298e@gmail.com
Changes in v2:
- Dropped property name change and driver updates.
- Link to v1: https://lore.kernel.org/r/20260606-crossbar-v1-0-f67f7cb9ee50@gmail.com
---
.../devicetree/bindings/arm/omap/crossbar.txt | 55 -------------
.../interrupt-controller/ti,irq-crossbar.yaml | 96 ++++++++++++++++++++++
2 files changed, 96 insertions(+), 55 deletions(-)
diff --git a/Documentation/devicetree/bindings/arm/omap/crossbar.txt b/Documentation/devicetree/bindings/arm/omap/crossbar.txt
deleted file mode 100644
index a43e4c7aba3d..000000000000
--- a/Documentation/devicetree/bindings/arm/omap/crossbar.txt
+++ /dev/null
@@ -1,55 +0,0 @@
-Some socs have a large number of interrupts requests to service
-the needs of its many peripherals and subsystems. All of the
-interrupt lines from the subsystems are not needed at the same
-time, so they have to be muxed to the irq-controller appropriately.
-In such places a interrupt controllers are preceded by an CROSSBAR
-that provides flexibility in muxing the device requests to the controller
-inputs.
-
-Required properties:
-- compatible : Should be "ti,irq-crossbar"
-- reg: Base address and the size of the crossbar registers.
-- interrupt-controller: indicates that this block is an interrupt controller.
-- ti,max-irqs: Total number of irqs available at the parent interrupt controller.
-- ti,max-crossbar-sources: Maximum number of crossbar sources that can be routed.
-- ti,reg-size: Size of a individual register in bytes. Every individual
- register is assumed to be of same size. Valid sizes are 1, 2, 4.
-- ti,irqs-reserved: List of the reserved irq lines that are not muxed using
- crossbar. These interrupt lines are reserved in the soc,
- so crossbar bar driver should not consider them as free
- lines.
-
-Optional properties:
-- ti,irqs-skip: This is similar to "ti,irqs-reserved", but these are for
- SOC-specific hard-wiring of those irqs which unexpectedly bypasses the
- crossbar. These irqs have a crossbar register, but still cannot be used.
-
-- ti,irqs-safe-map: integer which maps to a safe configuration to use
- when the interrupt controller irq is unused (when not provided, default is 0)
-
-Examples:
- crossbar_mpu: crossbar@4a002a48 {
- compatible = "ti,irq-crossbar";
- reg = <0x4a002a48 0x130>;
- ti,max-irqs = <160>;
- ti,max-crossbar-sources = <400>;
- ti,reg-size = <2>;
- ti,irqs-reserved = <0 1 2 3 5 6 131 132>;
- ti,irqs-skip = <10 133 139 140>;
- };
-
-Consumer:
-========
-See Documentation/devicetree/bindings/interrupt-controller/interrupts.txt and
-Documentation/devicetree/bindings/interrupt-controller/arm,gic.yaml for
-further details.
-
-An interrupt consumer on an SoC using crossbar will use:
- interrupts = <GIC_SPI request_number interrupt_level>
-
-Example:
- device_x@4a023000 {
- /* Crossbar 8 used */
- interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>;
- ...
- };
diff --git a/Documentation/devicetree/bindings/interrupt-controller/ti,irq-crossbar.yaml b/Documentation/devicetree/bindings/interrupt-controller/ti,irq-crossbar.yaml
new file mode 100644
index 000000000000..a919db1d0645
--- /dev/null
+++ b/Documentation/devicetree/bindings/interrupt-controller/ti,irq-crossbar.yaml
@@ -0,0 +1,96 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/interrupt-controller/ti,irq-crossbar.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Texas Instruments IRQ Crossbar
+
+maintainers:
+ - Sricharan R <r.sricharan@ti.com>
+
+description:
+ Some socs have a large number of interrupts requests to service the needs of
+ its many peripherals and subsystems. All of the interrupt lines from the
+ subsystems are not needed at the same time, so they have to be muxed to the
+ irq-controller appropriately. In such places a interrupt controllers are
+ preceded by an CROSSBAR that provides flexibility in muxing the device
+ requests to the controller inputs.
+
+properties:
+ compatible:
+ const: ti,irq-crossbar
+
+ reg:
+ maxItems: 1
+
+ interrupt-controller: true
+
+ '#interrupt-cells':
+ const: 3
+
+ ti,max-irqs:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description:
+ Total number of irqs available at the parent interrupt controller.
+ minimum: 1
+
+ ti,max-crossbar-sources:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description:
+ Maximum number of crossbar sources that can be routed.
+ minimum: 1
+
+ ti,reg-size:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description:
+ Size of a individual register in bytes. Every individual
+ register is assumed to be of same size.
+ enum: [1, 2, 4]
+
+ ti,irqs-reserved:
+ $ref: /schemas/types.yaml#/definitions/uint32-array
+ description:
+ List of the reserved irq lines that are not muxed using crossbar. These
+ interrupt lines are reserved in the soc, so crossbar bar driver should not
+ consider them as free lines.
+
+ ti,irqs-skip:
+ $ref: /schemas/types.yaml#/definitions/uint32-array
+ description:
+ Similar to "ti,irqs-reserved", but these are for SOC-specific hard-wiring
+ of those irqs which unexpectedly bypasses the crossbar. These irqs have a
+ crossbar register, but still cannot be used.
+
+ ti,irqs-safe-map:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description:
+ integer which maps to a safe configuration to use when the interrupt
+ controller irq is unused.
+ default: 0
+
+required:
+ - compatible
+ - reg
+ - interrupt-controller
+ - '#interrupt-cells'
+ - ti,max-irqs
+ - ti,max-crossbar-sources
+ - ti,reg-size
+ - ti,irqs-reserved
+
+additionalProperties: false
+
+examples:
+ - |
+ crossbar@4a002a48 {
+ compatible = "ti,irq-crossbar";
+ reg = <0x4a002a48 0x130>;
+ interrupt-controller;
+ #interrupt-cells = <3>;
+ ti,max-irqs = <160>;
+ ti,max-crossbar-sources = <400>;
+ ti,reg-size = <2>;
+ ti,irqs-reserved = <0 1 2 3 5 6 131 132>;
+ ti,irqs-skip = <10 133 139 140>;
+ };
---
base-commit: eb3f4b7426cfd2b79d65b7d37155480b32259a11
change-id: 20260528-crossbar-2b9a641d2146
Best regards,
--
Bhargav
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v3] dt-bindings: interrupt-controller: ti,irq-crossbar: Convert to DT schema
2026-06-11 21:12 [PATCH v3] dt-bindings: interrupt-controller: ti,irq-crossbar: Convert to DT schema Bhargav Joshi
@ 2026-06-15 21:01 ` Rob Herring (Arm)
2026-06-24 11:22 ` Konrad Dybcio
0 siblings, 1 reply; 5+ messages in thread
From: Rob Herring (Arm) @ 2026-06-15 21:01 UTC (permalink / raw)
To: Bhargav Joshi
Cc: simona.toaca, Krzysztof Kozlowski, m-chawdhry, daniel.baluta,
Thomas Gleixner, Sricharan R, linux-kernel, devicetree,
Conor Dooley, goledhruva
On Fri, 12 Jun 2026 02:42:29 +0530, Bhargav Joshi wrote:
> Convert TI irq-crossbar binding from text format to DT schema.
>
> As part of conversion following changes are made:
> - Add '#interrupt-cells' as a required property which was missing in
> text binding
> - As irq-crossbar is interrupt-controller. Move binding from
> bindings/arm/omap to bindings/interrupt-controller
>
> Signed-off-by: Bhargav Joshi <j.bhargav.u@gmail.com>
> ---
> Changes in v3:
> - Fixed typo in property description
> - Link to v2: https://lore.kernel.org/r/20260611-crossbar-v2-1-231d4f88298e@gmail.com
>
> Changes in v2:
> - Dropped property name change and driver updates.
> - Link to v1: https://lore.kernel.org/r/20260606-crossbar-v1-0-f67f7cb9ee50@gmail.com
> ---
> .../devicetree/bindings/arm/omap/crossbar.txt | 55 -------------
> .../interrupt-controller/ti,irq-crossbar.yaml | 96 ++++++++++++++++++++++
> 2 files changed, 96 insertions(+), 55 deletions(-)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] dt-bindings: interrupt-controller: ti,irq-crossbar: Convert to DT schema
2026-06-15 21:01 ` Rob Herring (Arm)
@ 2026-06-24 11:22 ` Konrad Dybcio
2026-06-24 15:49 ` Rob Herring
0 siblings, 1 reply; 5+ messages in thread
From: Konrad Dybcio @ 2026-06-24 11:22 UTC (permalink / raw)
To: Rob Herring (Arm), Bhargav Joshi
Cc: simona.toaca, Krzysztof Kozlowski, m-chawdhry, daniel.baluta,
Thomas Gleixner, Sricharan R, linux-kernel, devicetree,
Conor Dooley, goledhruva
On 6/15/26 11:01 PM, Rob Herring (Arm) wrote:
>
> On Fri, 12 Jun 2026 02:42:29 +0530, Bhargav Joshi wrote:
>> Convert TI irq-crossbar binding from text format to DT schema.
>>
>> As part of conversion following changes are made:
>> - Add '#interrupt-cells' as a required property which was missing in
>> text binding
>> - As irq-crossbar is interrupt-controller. Move binding from
>> bindings/arm/omap to bindings/interrupt-controller
>>
>> Signed-off-by: Bhargav Joshi <j.bhargav.u@gmail.com>
>> ---
>> Changes in v3:
>> - Fixed typo in property description
>> - Link to v2: https://lore.kernel.org/r/20260611-crossbar-v2-1-231d4f88298e@gmail.com
>>
>> Changes in v2:
>> - Dropped property name change and driver updates.
>> - Link to v1: https://lore.kernel.org/r/20260606-crossbar-v1-0-f67f7cb9ee50@gmail.com
>> ---
>> .../devicetree/bindings/arm/omap/crossbar.txt | 55 -------------
>> .../interrupt-controller/ti,irq-crossbar.yaml | 96 ++++++++++++++++++++++
>> 2 files changed, 96 insertions(+), 55 deletions(-)
>>
>
> Applied, thanks!
With:
$ dt-validate --version
2026.4
on next-20260623
I'm getting:
$ LC_ALL=C make ARCH=arm64 LLVM=1 -j24 dt_binding_check
SCHEMA Documentation/devicetree/bindings/processed-schema.json
Traceback (most recent call last):
File "/home/konrad/.local/bin/dt-mk-schema", line 6, in <module>
sys.exit(main())
~~~~^^
File "/home/konrad/.local/share/pipx/venvs/dtschema/lib/python3.14/site-packages/dtschema/mk_schema.py", line 28, in main
schemas = dtschema.DTValidator(args.schemas).schemas
~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^
File "/home/konrad/.local/share/pipx/venvs/dtschema/lib/python3.14/site-packages/dtschema/validator.py", line 399, in __init__
self.make_property_type_cache()
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
File "/home/konrad/.local/share/pipx/venvs/dtschema/lib/python3.14/site-packages/dtschema/validator.py", line 528, in make_property_type_cache
self.check_duplicate_property_types()
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
File "/home/konrad/.local/share/pipx/venvs/dtschema/lib/python3.14/site-packages/dtschema/validator.py", line 522, in check_duplicate_property_types
print(f"{self.schemas[sch_id]['$filename']}: {p}: multiple incompatible types: {v['type']}", file=sys.stderr)
~~~~~~~~~~~~^^^^^^^^
KeyError: 'http://devicetree.org/schemas/interrupt-controller/ti,irq-crossbar.yaml#'
make[2]: *** [Documentation/devicetree/bindings/Makefile:75: Documentation/devicetree/bindings/processed-schema.json] Błąd 1
make[2]: *** Kasuję plik 'Documentation/devicetree/bindings/processed-schema.json'
make[1]: *** [<snip>/linux/Makefile:1672: dt_binding_schemas] Błąd 2
make: *** [Makefile:248: __sub-make] Error 2
Konrad
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v3] dt-bindings: interrupt-controller: ti,irq-crossbar: Convert to DT schema
2026-06-24 11:22 ` Konrad Dybcio
@ 2026-06-24 15:49 ` Rob Herring
2026-06-25 7:51 ` Konrad Dybcio
0 siblings, 1 reply; 5+ messages in thread
From: Rob Herring @ 2026-06-24 15:49 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Bhargav Joshi, simona.toaca, Krzysztof Kozlowski, m-chawdhry,
daniel.baluta, Thomas Gleixner, Sricharan R, linux-kernel,
devicetree, Conor Dooley, goledhruva
On Wed, Jun 24, 2026 at 6:22 AM Konrad Dybcio <konradybcio@kernel.org> wrote:
>
> On 6/15/26 11:01 PM, Rob Herring (Arm) wrote:
> >
> > On Fri, 12 Jun 2026 02:42:29 +0530, Bhargav Joshi wrote:
> >> Convert TI irq-crossbar binding from text format to DT schema.
> >>
> >> As part of conversion following changes are made:
> >> - Add '#interrupt-cells' as a required property which was missing in
> >> text binding
> >> - As irq-crossbar is interrupt-controller. Move binding from
> >> bindings/arm/omap to bindings/interrupt-controller
> >>
> >> Signed-off-by: Bhargav Joshi <j.bhargav.u@gmail.com>
> >> ---
> >> Changes in v3:
> >> - Fixed typo in property description
> >> - Link to v2: https://lore.kernel.org/r/20260611-crossbar-v2-1-231d4f88298e@gmail.com
> >>
> >> Changes in v2:
> >> - Dropped property name change and driver updates.
> >> - Link to v1: https://lore.kernel.org/r/20260606-crossbar-v1-0-f67f7cb9ee50@gmail.com
> >> ---
> >> .../devicetree/bindings/arm/omap/crossbar.txt | 55 -------------
> >> .../interrupt-controller/ti,irq-crossbar.yaml | 96 ++++++++++++++++++++++
> >> 2 files changed, 96 insertions(+), 55 deletions(-)
> >>
> >
> > Applied, thanks!
>
> With:
>
> $ dt-validate --version
> 2026.4
There is 2026.6 now which fixes this.
>
> on next-20260623
>
> I'm getting:
>
> $ LC_ALL=C make ARCH=arm64 LLVM=1 -j24 dt_binding_check
> SCHEMA Documentation/devicetree/bindings/processed-schema.json
> Traceback (most recent call last):
> File "/home/konrad/.local/bin/dt-mk-schema", line 6, in <module>
> sys.exit(main())
> ~~~~^^
> File "/home/konrad/.local/share/pipx/venvs/dtschema/lib/python3.14/site-packages/dtschema/mk_schema.py", line 28, in main
> schemas = dtschema.DTValidator(args.schemas).schemas
> ~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^
> File "/home/konrad/.local/share/pipx/venvs/dtschema/lib/python3.14/site-packages/dtschema/validator.py", line 399, in __init__
> self.make_property_type_cache()
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
> File "/home/konrad/.local/share/pipx/venvs/dtschema/lib/python3.14/site-packages/dtschema/validator.py", line 528, in make_property_type_cache
> self.check_duplicate_property_types()
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
> File "/home/konrad/.local/share/pipx/venvs/dtschema/lib/python3.14/site-packages/dtschema/validator.py", line 522, in check_duplicate_property_types
> print(f"{self.schemas[sch_id]['$filename']}: {p}: multiple incompatible types: {v['type']}", file=sys.stderr)
> ~~~~~~~~~~~~^^^^^^^^
> KeyError: 'http://devicetree.org/schemas/interrupt-controller/ti,irq-crossbar.yaml#'
> make[2]: *** [Documentation/devicetree/bindings/Makefile:75: Documentation/devicetree/bindings/processed-schema.json] Błąd 1
> make[2]: *** Kasuję plik 'Documentation/devicetree/bindings/processed-schema.json'
> make[1]: *** [<snip>/linux/Makefile:1672: dt_binding_schemas] Błąd 2
> make: *** [Makefile:248: __sub-make] Error 2
We should fix this to avoid the splat, but that would still be a new
tool version.
So we either need to revert this and delay adding this schema or force
people to upgrade.
Rob
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v3] dt-bindings: interrupt-controller: ti,irq-crossbar: Convert to DT schema
2026-06-24 15:49 ` Rob Herring
@ 2026-06-25 7:51 ` Konrad Dybcio
0 siblings, 0 replies; 5+ messages in thread
From: Konrad Dybcio @ 2026-06-25 7:51 UTC (permalink / raw)
To: Rob Herring, Konrad Dybcio
Cc: Bhargav Joshi, simona.toaca, Krzysztof Kozlowski, m-chawdhry,
daniel.baluta, Thomas Gleixner, Sricharan R, linux-kernel,
devicetree, Conor Dooley, goledhruva
On 6/24/26 5:49 PM, Rob Herring wrote:
> On Wed, Jun 24, 2026 at 6:22 AM Konrad Dybcio <konradybcio@kernel.org> wrote:
>>
>> On 6/15/26 11:01 PM, Rob Herring (Arm) wrote:
>>>
>>> On Fri, 12 Jun 2026 02:42:29 +0530, Bhargav Joshi wrote:
>>>> Convert TI irq-crossbar binding from text format to DT schema.
>>>>
>>>> As part of conversion following changes are made:
>>>> - Add '#interrupt-cells' as a required property which was missing in
>>>> text binding
>>>> - As irq-crossbar is interrupt-controller. Move binding from
>>>> bindings/arm/omap to bindings/interrupt-controller
>>>>
>>>> Signed-off-by: Bhargav Joshi <j.bhargav.u@gmail.com>
>>>> ---
[...]
>> KeyError: 'http://devicetree.org/schemas/interrupt-controller/ti,irq-crossbar.yaml#'
>> make[2]: *** [Documentation/devicetree/bindings/Makefile:75: Documentation/devicetree/bindings/processed-schema.json] Błąd 1
>> make[2]: *** Kasuję plik 'Documentation/devicetree/bindings/processed-schema.json'
>> make[1]: *** [<snip>/linux/Makefile:1672: dt_binding_schemas] Błąd 2
>> make: *** [Makefile:248: __sub-make] Error 2
>
> We should fix this to avoid the splat, but that would still be a new
> tool version.
>
> So we either need to revert this and delay adding this schema or force
> people to upgrade.
I think we may find a static version check useful (i.e. something akin to
what scripts/cc-version.sh does with compilers) to make things more
obvious
Konrad
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-06-25 7:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-11 21:12 [PATCH v3] dt-bindings: interrupt-controller: ti,irq-crossbar: Convert to DT schema Bhargav Joshi
2026-06-15 21:01 ` Rob Herring (Arm)
2026-06-24 11:22 ` Konrad Dybcio
2026-06-24 15:49 ` Rob Herring
2026-06-25 7:51 ` Konrad Dybcio
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox