From: sashiko-bot@kernel.org
To: "Quentin Schulz" <foss+kernel@0leil.net>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH] arm64: dts: rockchip: fix eMMC reset polarity on PP-1516
Date: Fri, 12 Jun 2026 16:52:54 +0000 [thread overview]
Message-ID: <20260612165255.06FA81F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260612-pp1516-emmc-polarity-v1-1-4816c1c909f7@cherry.de>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Pre-existing issues:
- [High] Incomplete fix: identical incorrect eMMC reset polarity (GPIO_ACTIVE_HIGH) remains in multiple PX30 boards.
--
commit 764233a2abb692d41607851c93d3fed45fcab940
Author: Quentin Schulz <quentin.schulz@cherry.de>
arm64: dts: rockchip: fix eMMC reset polarity on PP-1516
This commit fixes the eMMC reset polarity for the px30-pp1516 board by
changing it to GPIO_ACTIVE_LOW to comply with the Jedec 5.1 specification.
The previous GPIO_ACTIVE_HIGH polarity caused eMMC devices with specific
RST_n_FUNCTION bitfield settings to be held in reset forever.
> diff --git a/arch/arm64/boot/dts/rockchip/px30-pp1516.dtsi b/arch/arm64/boot/dts/rockchip/px30-pp1516.dtsi
> index 192791993f059..02200de695d31 100644
> --- a/arch/arm64/boot/dts/rockchip/px30-pp1516.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/px30-pp1516.dtsi
> @@ -33,7 +33,7 @@ emmc_pwrseq: emmc-pwrseq {
> compatible = "mmc-pwrseq-emmc";
> pinctrl-0 = <&emmc_reset>;
> pinctrl-names = "default";
> - reset-gpios = <&gpio1 RK_PB3 GPIO_ACTIVE_HIGH>;
> + reset-gpios = <&gpio1 RK_PB3 GPIO_ACTIVE_LOW>;
[Severity: High]
This isn't a bug introduced by this patch, but does this same fix need to be
applied to other PX30 boards?
Looking at the tree, several other PX30 device trees still use the exact same
incorrect GPIO_ACTIVE_HIGH configuration for their emmc_pwrseq nodes:
arch/arm64/boot/dts/rockchip/px30-cobra.dtsi
arch/arm64/boot/dts/rockchip/px30-evb.dts
arch/arm64/boot/dts/rockchip/px30-firefly-jd4-core.dtsi
arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi
Will these boards also fail to boot if used with eMMC devices where the
RST_n_FUNCTION[162] bitfield is set to 0x1, or do they guarantee different
hardware behavior?
> };
>
> gpio-leds {
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260612-pp1516-emmc-polarity-v1-1-4816c1c909f7@cherry.de?part=1
prev parent reply other threads:[~2026-06-12 16:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-12 16:47 [PATCH] arm64: dts: rockchip: fix eMMC reset polarity on PP-1516 Quentin Schulz
2026-06-12 16:52 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260612165255.06FA81F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=foss+kernel@0leil.net \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox