Devicetree
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Linus Walleij <linusw@kernel.org>
Cc: Md Shofiqul Islam <shofiqtest@gmail.com>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] misc: lis3lv02d: set default click detection thresholds
Date: Fri, 12 Jun 2026 18:35:01 +0100	[thread overview]
Message-ID: <20260612183501.2c35df29@jic23-huawei> (raw)
In-Reply-To: <CAD++jLnK7uMo5U4S5B_5_p2tNbV87AeHHfv_RT=rhS58AAtHBw@mail.gmail.com>

On Fri, 12 Jun 2026 16:21:56 +0200
Linus Walleij <linusw@kernel.org> wrote:

> On Thu, Jun 11, 2026 at 5:41 PM Md Shofiqul Islam <shofiqtest@gmail.com> wrote:
> 
> > Several upstream board DTS files use st,click-thresh-x/y/z (the name
> > documented in the old lis302.txt binding), but the driver reads
> > st,click-threshold-x/y/z. As a result those boards have had click
> > detection silently broken since the DT properties were added.
> >
> > Set a default threshold of 10 for all three axes immediately after
> > the platform data allocation so those boards get working click
> > detection without requiring a DT change.
> >
> > The DT reads for st,click-threshold-x/y/z are unchanged so boards
> > using the correct name can still override the default.
> >
> > Fixes: 6a7740c7f5b2 ("lis3lv02d: add device-tree support")
> >
No blank line here.  Tags must always be in one block with no lines
in between them.

> > Signed-off-by: Md Shofiqul Islam <shofiqtest@gmail.com>  
> 
> Reviewed-by: Linus Walleij <linusw@kernel.org>
> 
> Yours,
> Linus Walleij


  reply	other threads:[~2026-06-12 17:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-11 15:41 [PATCH v2 0/3] lis302dl/lis3lv02d: fix click thresholds and add legacy YAML binding Md Shofiqul Islam
2026-06-11 15:41 ` [PATCH v2 1/3] misc: lis3lv02d: set default click detection thresholds Md Shofiqul Islam
2026-06-11 15:52   ` sashiko-bot
2026-06-12 14:21   ` Linus Walleij
2026-06-12 17:35     ` Jonathan Cameron [this message]
2026-06-11 15:41 ` [PATCH v2 2/3] dt-bindings: iio: st,st-sensors: remove lis302dl and lis3lv02d from deprecated list Md Shofiqul Islam
2026-06-12  9:07   ` Krzysztof Kozlowski
2026-06-11 15:41 ` [PATCH v2 3/3] dt-bindings: iio: accel: convert lis302 binding to YAML schema (v2) Md Shofiqul Islam
2026-06-11 15:52   ` sashiko-bot
2026-06-11 17:10   ` Conor Dooley
2026-06-12  9:10   ` Krzysztof Kozlowski
2026-06-12 14:16   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260612183501.2c35df29@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=shofiqtest@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox