Devicetree
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Konrad Dybcio <konradybcio@kernel.org>
Cc: Vinod Koul <vkoul@kernel.org>,
	 Neil Armstrong <neil.armstrong@linaro.org>,
	Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 Wesley Cheng <quic_wcheng@quicinc.com>,
	Iskren Chernev <me@iskren.info>,
	 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Bjorn Andersson <andersson@kernel.org>,
	 linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
	devicetree@vger.kernel.org,  linux-kernel@vger.kernel.org,
	Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Subject: Re: [PATCH 1/4] dt-bindings: phy: qcom,qusb2: Straighten out SM6125 and MSM8996
Date: Sat, 13 Jun 2026 20:36:22 +0200	[thread overview]
Message-ID: <20260613-impartial-cow-of-emphasis-e60cdc@quoll> (raw)
In-Reply-To: <20260610-topic-8996_61x5_qusb2phy-v1-1-d7135980e78f@oss.qualcomm.com>

On Wed, Jun 10, 2026 at 02:04:14PM +0200, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> SM6125 DT currently uses just the MSM8996 compatible (without a primary
> SM6125-specific one). This is not only wrong for the reasons of
> violating guidelines, but also happens to not be valid.
> 
> The MSM8996 PHY is quite similar, although it requies a different init
> sequence (for arch reasons). MSM8996 also needs different power
> plumbing, as the VDD supply is fed through VDD_MX (which we define as
> a power domain rather than a regulator), unlike on SM6125.
> 
> The init sequence seems to have been "good enough", but now that the
> bindings clearly diverge, add a new compatible for SM6125 with a SM6115
> fallback (as they seem to be an exact match from the SW interface POV).
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
>  .../devicetree/bindings/phy/qcom,qusb2-phy.yaml    | 31 ++++++++++++++++++++--
>  1 file changed, 29 insertions(+), 2 deletions(-)

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof


  parent reply	other threads:[~2026-06-13 18:36 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-10 12:04 [PATCH 0/4] Fix up QUSB2 PHY description for MSM8996/SM61[12]5 Konrad Dybcio
2026-06-10 12:04 ` [PATCH 1/4] dt-bindings: phy: qcom,qusb2: Straighten out SM6125 and MSM8996 Konrad Dybcio
2026-06-10 12:25   ` sashiko-bot
2026-06-13 18:36   ` Krzysztof Kozlowski [this message]
2026-06-10 12:04 ` [PATCH 2/4] phy: qcom-qusb2: Fix SM6115 init sequence Konrad Dybcio
2026-06-10 12:57   ` Abel Vesa
2026-06-10 13:20   ` Dmitry Baryshkov
2026-06-14 12:29   ` Iskren Chernev
2026-06-15 10:44     ` Konrad Dybcio
2026-06-17 12:48       ` Iskren Chernev
2026-06-17 13:03         ` Konrad Dybcio
2026-06-10 12:04 ` [PATCH 3/4] arm64: dts: qcom: msm8996: Add VDD_MX to QUSB2 PHYs Konrad Dybcio
2026-06-10 12:18   ` sashiko-bot
2026-06-10 13:22     ` Dmitry Baryshkov
2026-06-10 13:21   ` Dmitry Baryshkov
2026-06-10 13:33     ` Konrad Dybcio
2026-06-10 12:04 ` [PATCH 4/4] arm64: dts: qcom: sm6125: Fix QUSB2 compatible Konrad Dybcio
2026-06-10 12:53   ` Dmitry Baryshkov
2026-06-10 12:49 ` [PATCH 0/4] Fix up QUSB2 PHY description for MSM8996/SM61[12]5 Konrad Dybcio
2026-06-10 13:03   ` Dmitry Baryshkov
2026-06-10 13:13     ` Konrad Dybcio
2026-06-10 13:20       ` Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260613-impartial-cow-of-emphasis-e60cdc@quoll \
    --to=krzk@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=me@iskren.info \
    --cc=neil.armstrong@linaro.org \
    --cc=quic_wcheng@quicinc.com \
    --cc=robh@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox