Re: [PATCH] dt-bindings: sound: nvidia,tegra30-ahub: Convert to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `allOf` conditional block for `nvidia,tegra124-ahub` fails to constrain the `reg` property count, allowing missing register regions to silently pass validation.
--

commit 9a0f1d546144b78d414e177cfaf59f6770e9ba9b
Author: Charan Pedumuru <charan.pedumuru@gmail.com>

dt-bindings: sound: nvidia,tegra30-ahub: Convert to DT schema

Converts the NVIDIA Tegra Audio Hub (AHUB) binding from text to DT schema.
The patch enforces per-SoC differences in reset-names, dma-names, and reg
entry counts using allOf conditionals.

> diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra30-ahub.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra30-ahub.yaml
> new file mode 100644
> index 0000000000000..82738058f6722
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra30-ahub.yaml
[ ... ]
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: nvidia,tegra124-ahub
> +    then:
> +      properties:
> +        "#address-cells":
> +          const: 2

[Severity: Low]
Does the tegra124-ahub conditional need to enforce the reg property count?

The commit message mentions that reg entry counts described in the text
binding are now enforced via allOf conditionals, but this block omits the
reg constraints for tegra124-ahub. It falls back to the top-level
minItems: 2, maxItems: 3, which could allow a tegra124-ahub node with only
2 register entries to incorrectly pass schema validation. Since tegra114-ahub
enforces minItems: 3 and maxItems: 3, should this block do the same?

> +
> +        "#size-cells":
> +          const: 2
> +
> +        resets:
> +          minItems: 21
> +          maxItems: 21

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260613-nvidia-ahub-v1-1-5b7e85301736@gmail.com?part=1