From: sashiko-bot@kernel.org
To: "Charan Pedumuru" <charan.pedumuru@gmail.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH v4 1/2] arm: dts: st: align node patterns with established convention
Date: Sat, 13 Jun 2026 09:48:44 +0000 [thread overview]
Message-ID: <20260613094844.EEA7D1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260613-st-mmc-v4-1-b3c385617c16@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Renaming 'sdhci@...' nodes to 'mmc@...' in the base dtsi file leaves overrides in derived dtsi and dts files orphaned, causing node duplication and completely breaking MMC functionality.
--
commit 40b6fa41749cf01adbee4227ca47061d9fbb6688
Author: Charan Pedumuru <charan.pedumuru@gmail.com>
arm: dts: st: align node patterns with established convention
This commit updates ST MMC DTS node patterns to match established convention
by renaming the base sdhci nodes to mmc.
> diff --git a/arch/arm/boot/dts/st/stih407-family.dtsi b/arch/arm/boot/dts/st/stih407-family.dtsi
> index 3e6a0542e3aea..08acba209c564 100644
> --- a/arch/arm/boot/dts/st/stih407-family.dtsi
> +++ b/arch/arm/boot/dts/st/stih407-family.dtsi
> @@ -596,7 +596,7 @@ spi@9542000 {
> status = "disabled";
> };
>
> - mmc0: sdhci@9060000 {
> + mmc0: mmc@9060000 {
[Severity: High]
Does renaming these base nodes to mmc@... leave downstream overrides
orphaned?
Looking at board files like arch/arm/boot/dts/st/stih410-b2260.dts and
arch/arm/boot/dts/st/stih418-b2199.dts, there are still overrides using
the old names:
mmc0: sdhci@9060000 {
pinctrl-0 = <&pinctrl_sd0>;
bus-width = <4>;
status = "okay";
};
Because the base node is renamed here without updating the downstream files,
will the DTC compiler treat the downstream overrides as new node declarations
rather than property merges?
This would leave the base mmc@9060000 node disabled, while the new
sdhci@9060000 node would lack essential properties like compatible and reg,
preventing the kernel from binding the MMC driver to the hardware.
> compatible = "st,sdhci-stih407", "st,sdhci";
> status = "disabled";
> reg = <0x09060000 0x7ff>, <0x9061008 0x20>;
[ ... ]
> - mmc1: sdhci@9080000 {
> + mmc1: mmc@9080000 {
[Severity: High]
Are there similar orphaned overrides for this node?
Checking arch/arm/boot/dts/st/stih418-b2199.dts, it appears this node is
also overridden using the old name:
mmc1: sdhci@9080000 {
status = "okay";
};
Would this result in the same missing compatible properties and disabled
base node?
> compatible = "st,sdhci-stih407", "st,sdhci";
> status = "disabled";
> reg = <0x09080000 0x7ff>;
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260613-st-mmc-v4-0-b3c385617c16@gmail.com?part=1
next prev parent reply other threads:[~2026-06-13 9:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-13 9:39 [PATCH v4 0/2] dt-bindings: mmc: st,sdhci: convert STMicroelectronics SDHCI-ST MMC/SD Controller controller binding to YAML Charan Pedumuru
2026-06-13 9:39 ` [PATCH v4 1/2] arm: dts: st: align node patterns with established convention Charan Pedumuru
2026-06-13 9:48 ` sashiko-bot [this message]
2026-06-13 9:39 ` [PATCH v4 2/2] dt-bindings: mmc: st,sdhci: Convert to DT schema Charan Pedumuru
2026-06-13 9:48 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260613094844.EEA7D1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=charan.pedumuru@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox