From: Jonathan Cameron <jic23@kernel.org>
To: Sirat <email@sirat.me>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: iio: magnetometer: add QST QMC5883L Sensor
Date: Sat, 13 Jun 2026 12:18:15 +0100 [thread overview]
Message-ID: <20260613121815.09b18d3a@jic23-huawei> (raw)
In-Reply-To: <CANn+LW+OSfo3u+7wZu11j7tQd-PGyhrz3a9+st-FwjOLbT4NBw@mail.gmail.com>
On Sat, 13 Jun 2026 14:57:42 +0600
Sirat <email@sirat.me> wrote:
> On Fri, Jun 12, 2026 at 10:30 PM Jonathan Cameron <jic23@kernel.org> wrote:
> >
> > On Fri, 12 Jun 2026 18:45:26 +0600
> > Siratul Islam <email@sirat.me> wrote:
> >
> > > Add devicetree binding for the QST QMC5883L 3-Axis Magnetic Sensor
> > > connected via i2c.
> > > Interrupt not implemented in driver but kept in the binding for future
> > > addition.
> > No need to mention that
> Got it. In the past I was advised to mention certain choices in the
> commit message. I am still looking for the balance.
Sure. Generally dt-bindings should never mention the driver.
Despite being in the kernel tree they are not tightly coupled with
the drivers and indeed are pulled into other projects.
Jonathan
> >
> > The rest looks good to me.
> >
> > Thanks,
> >
> > Jonathan
> >
> Thanks
> Sirat
next prev parent reply other threads:[~2026-06-13 11:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-12 12:45 [PATCH 0/3] iio: magnetometer: add driver for QST QMC5883L Sensor Siratul Islam
2026-06-12 12:45 ` [PATCH 1/3] dt-bindings: add entry for qstcorp Siratul Islam
2026-06-12 16:49 ` Conor Dooley
2026-06-12 12:45 ` [PATCH 2/3] dt-bindings: iio: magnetometer: add QST QMC5883L Sensor Siratul Islam
2026-06-12 13:13 ` Joshua Crofts
2026-06-12 13:45 ` Jonathan Cameron
2026-06-13 15:39 ` David Lechner
2026-06-12 16:30 ` Jonathan Cameron
2026-06-13 8:57 ` Sirat
2026-06-13 11:18 ` Jonathan Cameron [this message]
2026-06-12 12:45 ` [PATCH 3/3] iio: magnetometer: add driver for " Siratul Islam
2026-06-12 12:56 ` sashiko-bot
2026-06-12 13:49 ` Joshua Crofts
2026-06-12 16:35 ` Jonathan Cameron
2026-06-13 8:01 ` Sirat
2026-06-12 17:02 ` Jonathan Cameron
2026-06-13 8:47 ` Sirat
2026-06-13 11:33 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260613121815.09b18d3a@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=email@sirat.me \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox