[PATCH 0/3] of/fdt, LoongArch, MIPS: fix misleading reservation success message

[PATCH 0/3] of/fdt, LoongArch, MIPS: fix misleading reservation success message

[Sang-Heon Jeon]

While reading the elfcorehdr reservation paths I noticed that
fdt_reserve_elfcorehdr(), LoongArch's arch_reserve_vmcore() and MIPS's
mips_reserve_vmcore() ignore the return value of memblock_reserve() and
print a success message even when the reservation fails.

memblock_reserve() is unlikely to fail this early in boot. However,
printing success on a failed reservation is misleading. I think it is
worth fixing, but feel free to drop it if you disagree.

The three call sites are in different trees, so I split the change into
one patch per arch/subsystem. The patches are independent and can be
applied separately.

Sang-Heon Jeon (3):
  of/fdt: fix misleading elfcorehdr reservation success message
  LoongArch: fix misleading elfcorehdr reservation success message
  MIPS: fix misleading elfcorehdr reservation success message

 arch/loongarch/kernel/setup.c | 5 ++++-
 arch/mips/kernel/setup.c      | 7 +++++--
 drivers/of/fdt.c              | 5 ++++-
 3 files changed, 13 insertions(+), 4 deletions(-)

-- 
2.43.0

[PATCH 1/3] of/fdt: fix misleading elfcorehdr reservation success message

[Sang-Heon Jeon]

fdt_reserve_elfcorehdr() does not check the return value of
memblock_reserve(), so a success message is falsely printed when the
reservation fails.

Check the return value and warn on failure instead.

Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
---
 drivers/of/fdt.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
index 26f66046cc32..d985c07d7c5c 100644
--- a/drivers/of/fdt.c
+++ b/drivers/of/fdt.c
@@ -479,7 +479,10 @@ static void __init fdt_reserve_elfcorehdr(void)
 		return;
 	}
 
-	memblock_reserve(elfcorehdr_addr, elfcorehdr_size);
+	if (memblock_reserve(elfcorehdr_addr, elfcorehdr_size)) {
+		pr_warn("Failed to reserve memory for elfcorehdr\n");
+		return;
+	}
 
 	pr_info("Reserving %llu KiB of memory at 0x%llx for elfcorehdr\n",
 		elfcorehdr_size >> 10, elfcorehdr_addr);
-- 
2.43.0

[PATCH 2/3] LoongArch: fix misleading elfcorehdr reservation success message

[Sang-Heon Jeon]

arch_reserve_vmcore() does not check the return value of
memblock_reserve(), so a success message is falsely printed when the
reservation fails.

Check the return value and warn on failure instead.

Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
---
 arch/loongarch/kernel/setup.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/arch/loongarch/kernel/setup.c b/arch/loongarch/kernel/setup.c
index 839b23edee87..702fb3c2b3c9 100644
--- a/arch/loongarch/kernel/setup.c
+++ b/arch/loongarch/kernel/setup.c
@@ -255,7 +255,10 @@ static void __init arch_reserve_vmcore(void)
 		return;
 	}
 
-	memblock_reserve(elfcorehdr_addr, elfcorehdr_size);
+	if (memblock_reserve(elfcorehdr_addr, elfcorehdr_size)) {
+		pr_warn("Failed to reserve memory for elfcorehdr\n");
+		return;
+	}
 
 	pr_info("Reserving %llu KiB of memory at 0x%llx for elfcorehdr\n",
 		elfcorehdr_size >> 10, elfcorehdr_addr);
-- 
2.43.0

[PATCH 3/3] MIPS: fix misleading elfcorehdr reservation success message

[Sang-Heon Jeon]

mips_reserve_vmcore() does not check the return value of
memblock_reserve(), so a success message is falsely printed when the
reservation fails.

Reserve before printing the success message. Check the return value and
warn on failure instead.

Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
---
 arch/mips/kernel/setup.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c
index 1ae6d0c0e1d6..c7769ed882e8 100644
--- a/arch/mips/kernel/setup.c
+++ b/arch/mips/kernel/setup.c
@@ -437,10 +437,13 @@ static void __init mips_reserve_vmcore(void)
 		}
 	}
 
+	if (memblock_reserve(elfcorehdr_addr, elfcorehdr_size)) {
+		pr_warn("Failed to reserve memory for kdump\n");
+		return;
+	}
+
 	pr_info("Reserving %ldKB of memory at %ldKB for kdump\n",
 		(unsigned long)elfcorehdr_size >> 10, (unsigned long)elfcorehdr_addr >> 10);
-
-	memblock_reserve(elfcorehdr_addr, elfcorehdr_size);
 #endif
 }
 
-- 
2.43.0