From: Krzysztof Kozlowski <krzk@kernel.org>
To: sashiko-reviews@lists.linux.dev
Cc: Teja Sai Charan B <tejaasaye@gmail.com>,
robh@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2] dt-bindings: rtc: Convert rtc-cmos binding to YAML
Date: Wed, 17 Jun 2026 10:13:19 +0200 [thread overview]
Message-ID: <20260617-practical-blue-collie-dd94ca@quoll> (raw)
In-Reply-To: <20260616090404.534451F000E9@smtp.kernel.org>
On Tue, Jun 16, 2026 at 09:04:03AM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
> - [Low] The node name in the YAML example uses a unit address that does not match its 'reg' property, which will cause a dtc warning and fail `make dt_binding_check`.
> - [Low] A stray file `result.txt` containing intermediate search and build output was accidentally included in the patch.
> - [Low] Important explanatory text about firmware initialization was dropped during the conversion to YAML.
Please address Sashiko reports as well.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-06-17 8:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-16 8:56 [PATCH v2] dt-bindings: rtc: Convert rtc-cmos binding to YAML Teja Sai Charan B
2026-06-16 9:04 ` sashiko-bot
2026-06-17 8:13 ` Krzysztof Kozlowski [this message]
2026-06-17 8:12 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260617-practical-blue-collie-dd94ca@quoll \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tejaasaye@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox