Devicetree
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: sound: add toshiba,apb-dummy-codec binding
@ 2026-06-16 18:56 Pablo D. Bergamasco
  2026-06-16 20:23 ` Mark Brown
  2026-06-17 10:50 ` Krzysztof Kozlowski
  0 siblings, 2 replies; 4+ messages in thread
From: Pablo D. Bergamasco @ 2026-06-16 18:56 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley
  Cc: Vaibhav Agarwal, Mark Greer, Liam Girdwood, Mark Brown,
	linux-sound, devicetree, linux-kernel, Pablo D. Bergamasco

Add device tree binding documentation for the Toshiba APBridge
dummy ALSA SoC codec used in the Greybus audio framework.

Fixes the following checkpatch warning:
  WARNING: DT compatible string appears un-documented

Signed-off-by: Pablo D. Bergamasco <danpablo@gmail.com>
---
 .../sound/toshiba,apb-dummy-codec.yaml        | 33 +++++++++++++++++++
 MAINTAINERS                                   |  1 +
 2 files changed, 34 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/toshiba,apb-dummy-codec.yaml

diff --git a/Documentation/devicetree/bindings/sound/toshiba,apb-dummy-codec.yaml b/Documentation/devicetree/bindings/sound/toshiba,apb-dummy-codec.yaml
new file mode 100644
index 000000000000..e0542feeb980
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/toshiba,apb-dummy-codec.yaml
@@ -0,0 +1,33 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/toshiba,apb-dummy-codec.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Toshiba APBridge Dummy ALSA SoC Codec
+
+maintainers:
+  - Vaibhav Agarwal <vaibhav.agarwal@linaro.org>
+
+description:
+  The APBridge dummy codec is part of the Greybus audio framework,
+  used in Project Ara modular phone hardware. It provides a dummy
+  ALSA SoC codec driver for the APBridge audio interface, enabling
+  audio streaming between Greybus modules and the host processor
+  via the APBridge protocol.
+
+properties:
+  compatible:
+    const: toshiba,apb-dummy-codec
+
+required:
+  - compatible
+
+additionalProperties: false
+
+examples:
+  - |
+    codec {
+        compatible = "toshiba,apb-dummy-codec";
+    };
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index b2040011a386..b6b4b488c0f7 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -11077,6 +11077,7 @@ GREYBUS AUDIO PROTOCOLS DRIVERS
 M:	Vaibhav Agarwal <vaibhav.sr@gmail.com>
 M:	Mark Greer <mgreer@animalcreek.com>
 S:	Maintained
+F:	Documentation/devicetree/bindings/sound/toshiba,apb-dummy-codec.yaml
 F:	drivers/staging/greybus/audio_apbridgea.c
 F:	drivers/staging/greybus/audio_apbridgea.h
 F:	drivers/staging/greybus/audio_codec.c
-- 
2.54.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: sound: add toshiba,apb-dummy-codec binding
  2026-06-16 18:56 [PATCH] dt-bindings: sound: add toshiba,apb-dummy-codec binding Pablo D. Bergamasco
@ 2026-06-16 20:23 ` Mark Brown
  2026-06-17 10:50 ` Krzysztof Kozlowski
  1 sibling, 0 replies; 4+ messages in thread
From: Mark Brown @ 2026-06-16 20:23 UTC (permalink / raw)
  To: Pablo D. Bergamasco
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Vaibhav Agarwal,
	Mark Greer, Liam Girdwood, linux-sound, devicetree, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 525 bytes --]

On Tue, Jun 16, 2026 at 03:56:19PM -0300, Pablo D. Bergamasco wrote:
> Add device tree binding documentation for the Toshiba APBridge
> dummy ALSA SoC codec used in the Greybus audio framework.

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: sound: add toshiba,apb-dummy-codec binding
  2026-06-16 18:56 [PATCH] dt-bindings: sound: add toshiba,apb-dummy-codec binding Pablo D. Bergamasco
  2026-06-16 20:23 ` Mark Brown
@ 2026-06-17 10:50 ` Krzysztof Kozlowski
  2026-06-17 14:55   ` Pablo D. Bergamasco
  1 sibling, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2026-06-17 10:50 UTC (permalink / raw)
  To: Pablo D. Bergamasco
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Vaibhav Agarwal,
	Mark Greer, Liam Girdwood, Mark Brown, linux-sound, devicetree,
	linux-kernel

On Tue, Jun 16, 2026 at 03:56:19PM -0300, Pablo D. Bergamasco wrote:
> Add device tree binding documentation for the Toshiba APBridge
> dummy ALSA SoC codec used in the Greybus audio framework.
> 
> Fixes the following checkpatch warning:
>   WARNING: DT compatible string appears un-documented

Nope. We don't take bindings for staging. Isn't this documented in
staging docs already?

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: sound: add toshiba,apb-dummy-codec binding
  2026-06-17 10:50 ` Krzysztof Kozlowski
@ 2026-06-17 14:55   ` Pablo D. Bergamasco
  0 siblings, 0 replies; 4+ messages in thread
From: Pablo D. Bergamasco @ 2026-06-17 14:55 UTC (permalink / raw)
  To: krzk
  Cc: broonie, conor+dt, danpablo, devicetree, krzk+dt, lgirdwood,
	linux-kernel, linux-sound, mgreer, robh, vaibhav.sr

On Wed, Jun 17, 2026, Krzysztof Kozlowski wrote:
> Nope. We don't take bindings for staging. Isn't this documented in
> staging docs already?

I checked drivers/staging/greybus/Documentation/ and found only
firmware and sysfs documentation. There is no existing DT binding
documentation for the "toshiba,apb-dummy-codec" compatible string.

Should I add the binding documentation within the staging directory
itself, or is there a preferred approach for staging drivers?

Best regards,
Pablo D. Bergamasco

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-06-17 14:55 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-16 18:56 [PATCH] dt-bindings: sound: add toshiba,apb-dummy-codec binding Pablo D. Bergamasco
2026-06-16 20:23 ` Mark Brown
2026-06-17 10:50 ` Krzysztof Kozlowski
2026-06-17 14:55   ` Pablo D. Bergamasco

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox