Re: [PATCH 2/2] dt-bindings: iio: st-sensors: drop lis302dl-spi from deprecated list

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incorrect Schema Removal / Broken Validation for st,lis302dl-spi
--

commit 23c740836661eab02e0a98566f673ed373f8b4d3
Author: Jad Keskes <inasj268@gmail.com>

dt-bindings: iio: st-sensors: drop lis302dl-spi from deprecated list

This commit removes the st,lis302dl-spi compatible string from the deprecated
list in the IIO st-sensors binding. It claims the compatible string is only
used by the misc driver.

> st,lis302dl-spi is only used by the misc/lis3lv02d driver. Its
> binding is now in Documentation/devicetree/bindings/misc/.

[Severity: Medium]
Is this statement accurate? Looking at drivers/iio/accel/st_accel_spi.c, the
IIO SPI driver still explicitly matches st,lis302dl-spi:

drivers/iio/accel/st_accel_spi.c:st_accel_of_match[] = {
	{
		/* An older compatible */
		.compatible = "st,lis302dl-spi",
		.data = LIS3LV02DL_ACCEL_DEV_NAME,
	},

> diff --git a/Documentation/devicetree/bindings/iio/st,st-sensors.yaml b/Documentation/devicetree/bindings/iio/st,st-sensors.yaml
> index a1a958215cdb7..2a5451589fabf 100644
> --- a/Documentation/devicetree/bindings/iio/st,st-sensors.yaml
> +++ b/Documentation/devicetree/bindings/iio/st,st-sensors.yaml
> @@ -90,10 +90,8 @@ properties:
>            - st,lsm9ds0-imu
>        - description: Deprecated bindings
>          enum:
> -          - st,lis302dl-spi

[Severity: Medium]
If st,lis302dl-spi is removed from the IIO binding, won't dtbs_check fail for
any valid device tree that pairs this compatible string with standard IIO
properties (such as vdd-supply or mount-matrix)?

Since the misc binding (st,lis3lv02d.yaml) enforces additionalProperties: false,
it would reject these IIO properties. It appears st,lis3lv02d was kept in the
schema for the exact same reason that st,lis302dl-spi should be kept.

>            - st,lis3lv02d
>          deprecated: true
> -
>    reg:
>      maxItems: 1

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260619115649.840676-1-inasj268@gmail.com?part=2