Re: [PATCH v5] dt-bindings: misc: convert lis302.txt to YAML

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The YAML schema incorrectly forbids the `Vdd-supply` and `Vdd_IO-supply` properties for the SPI variant and contains a redundant `select` block.
--

commit 124e32c58b0e195eb97adbc2880712f6df5eb1b2
Author: Jad Keskes <inasj268@gmail.com>

dt-bindings: misc: convert lis302.txt to YAML

This commit converts the old lis302.txt dt-binding to YAML format,
supporting the st,lis3lv02d, st,lis302dl-spi, st,lis331dlh, and
st,lis33de compatibles. It retains old property names as deprecated
to maintain backward compatibility with existing device trees.

> diff --git a/Documentation/devicetree/bindings/misc/st,lis3lv02d.yaml b/Documentation/devicetree/bindings/misc/st,lis3lv02d.yaml
> new file mode 100644
> index 0000000000000..c73371b754a1e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/misc/st,lis3lv02d.yaml

[ ... ]

> +description:
> +  This binding describes the STMicroelectronics accelerometers supported by
> +  the misc/lis3lv02d driver. This driver provides input (joystick) and
> +  hardware monitoring support, in contrast to the IIO st-accel driver which
> +  also supports some of these devices.
> +  Refer to Documentation/devicetree/bindings/iio/st,st-sensors.yaml for the
> +  IIO binding.
> +
> +select:
> +  anyOf:
> +    - properties:
> +        compatible:
> +          contains:
> +            const: st,lis302dl-spi
> +    - properties:
> +        compatible:
> +          contains:
> +            const: st,lis331dlh
> +    - properties:
> +        compatible:
> +          contains:
> +            const: st,lis33de
> +    - properties:
> +        compatible:
> +          contains:
> +            const: st,lis3lv02d
> +  required:
> +    - compatible
> +
> +properties:

[Severity: Medium]
Is this explicit select block necessary? The dt-schema tooling
automatically selects bindings based on the top-level compatible
property definition, making this manual select block redundant.

[ ... ]

> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          not:
> +            contains:
> +              const: st,lis302dl-spi
> +    then:
> +      required:
> +        - Vdd-supply
> +        - Vdd_IO-supply
> +    else:
> +      properties:
> +        Vdd-supply: false
> +        Vdd_IO-supply: false

[Severity: Medium]
Does setting these properties to false incorrectly enforce a hardware
abstraction violation? The physical chip requires power to operate
regardless of whether it uses the SPI bus or I2C. Device tree bindings
should describe the hardware, not the current limitations of the driver code.

> +      required:
> +        - spi-max-frequency
> +        - interrupts
> +
> +required:

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260619125902.893742-1-inasj268@gmail.com?part=1