Devicetree
 help / color / mirror / Atom feed
* [PATCH 1/2] dt-bindings: thermal: amlogic: Fix missing header in the example
@ 2026-06-22 10:02 Krzysztof Kozlowski
  2026-06-22 10:02 ` [PATCH 2/2] dt-bindings: thermal: amlogic: Correct 'reg' " Krzysztof Kozlowski
  2026-06-22 16:45 ` [PATCH 1/2] dt-bindings: thermal: amlogic: Fix missing header " Conor Dooley
  0 siblings, 2 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2026-06-22 10:02 UTC (permalink / raw)
  To: Guillaume La Roque, Rafael J. Wysocki, Daniel Lezcano, Zhang Rui,
	Lukasz Luba, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Ronald Claveau, linux-pm, linux-amlogic, devicetree, linux-kernel
  Cc: Krzysztof Kozlowski

Usage of defines from headers requires including relevant header,
otherwise dt_binding_check fails:

  Lexical error: Documentation/devicetree/bindings/thermal/amlogic,thermal.example.dts:59.27-34 Unexpected 'GIC_SPI'
  Lexical error: Documentation/devicetree/bindings/thermal/amlogic,thermal.example.dts:59.38-57 Unexpected 'IRQ_TYPE_LEVEL_HIGH'
  Lexical error: Documentation/devicetree/bindings/thermal/amlogic,thermal.example.dts:60.37-45 Unexpected 'CLKID_TS'

Fixes: b1c8ccdbd4e9 ("dt-bindings: thermal: amlogic: Add support for T7")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

---

Fix for current RC - commit already pulled in merge window.

This should be applied fast to fix current RC, thus maybe Rob?
---
 Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml b/Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml
index e28612510d67..d8f7f3eb7ae2 100644
--- a/Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml
+++ b/Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml
@@ -87,6 +87,9 @@ examples:
         amlogic,ao-secure = <&sec_AO>;
     };
   - |
+    #include <dt-bindings/clock/amlogic,t7-peripherals-clkc.h>
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+
     temperature-sensor@20000 {
         compatible = "amlogic,t7-thermal";
         reg = <0x0 0x20000 0x0 0x50>;
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] dt-bindings: thermal: amlogic: Correct 'reg' in the example
  2026-06-22 10:02 [PATCH 1/2] dt-bindings: thermal: amlogic: Fix missing header in the example Krzysztof Kozlowski
@ 2026-06-22 10:02 ` Krzysztof Kozlowski
  2026-06-22 16:45   ` Conor Dooley
  2026-06-22 16:45 ` [PATCH 1/2] dt-bindings: thermal: amlogic: Fix missing header " Conor Dooley
  1 sibling, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2026-06-22 10:02 UTC (permalink / raw)
  To: Guillaume La Roque, Rafael J. Wysocki, Daniel Lezcano, Zhang Rui,
	Lukasz Luba, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Ronald Claveau, linux-pm, linux-amlogic, devicetree, linux-kernel
  Cc: Krzysztof Kozlowski

The example DTS is tested in a wrapped node with address/size-cells=1,
thus reg had incorrect entry leading to dt_binding_check fails:

  thermal/amlogic,thermal.example.dtb: temperature-sensor@20000 (amlogic,t7-thermal): reg: [[0, 131072], [0, 80]] is too long

Fixes: b1c8ccdbd4e9 ("dt-bindings: thermal: amlogic: Add support for T7")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
 Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml b/Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml
index d8f7f3eb7ae2..8cfa44dcda58 100644
--- a/Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml
+++ b/Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml
@@ -92,7 +92,7 @@ examples:
 
     temperature-sensor@20000 {
         compatible = "amlogic,t7-thermal";
-        reg = <0x0 0x20000 0x0 0x50>;
+        reg = <0x20000 0x50>;
         interrupts = <GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>;
         clocks = <&clkc_periphs CLKID_TS>;
         #thermal-sensor-cells = <0>;
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] dt-bindings: thermal: amlogic: Fix missing header in the example
  2026-06-22 10:02 [PATCH 1/2] dt-bindings: thermal: amlogic: Fix missing header in the example Krzysztof Kozlowski
  2026-06-22 10:02 ` [PATCH 2/2] dt-bindings: thermal: amlogic: Correct 'reg' " Krzysztof Kozlowski
@ 2026-06-22 16:45 ` Conor Dooley
  1 sibling, 0 replies; 4+ messages in thread
From: Conor Dooley @ 2026-06-22 16:45 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Guillaume La Roque, Rafael J. Wysocki, Daniel Lezcano, Zhang Rui,
	Lukasz Luba, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Ronald Claveau, linux-pm, linux-amlogic, devicetree, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 75 bytes --]

Acked-by: Conor Dooley <conor.dooley@microchip.com>
pw-bot: not-applicable

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] dt-bindings: thermal: amlogic: Correct 'reg' in the example
  2026-06-22 10:02 ` [PATCH 2/2] dt-bindings: thermal: amlogic: Correct 'reg' " Krzysztof Kozlowski
@ 2026-06-22 16:45   ` Conor Dooley
  0 siblings, 0 replies; 4+ messages in thread
From: Conor Dooley @ 2026-06-22 16:45 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Guillaume La Roque, Rafael J. Wysocki, Daniel Lezcano, Zhang Rui,
	Lukasz Luba, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Ronald Claveau, linux-pm, linux-amlogic, devicetree, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 53 bytes --]

Acked-by: Conor Dooley <conor.dooley@microchip.com>


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-06-22 16:45 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-22 10:02 [PATCH 1/2] dt-bindings: thermal: amlogic: Fix missing header in the example Krzysztof Kozlowski
2026-06-22 10:02 ` [PATCH 2/2] dt-bindings: thermal: amlogic: Correct 'reg' " Krzysztof Kozlowski
2026-06-22 16:45   ` Conor Dooley
2026-06-22 16:45 ` [PATCH 1/2] dt-bindings: thermal: amlogic: Fix missing header " Conor Dooley

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox