Re: [PATCH v6 3/4] reset: cix: add sky1 audss auxiliary reset driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] `sky1_audss_reset_status()` incorrectly reports the reset state due to an inverted active-low logic check, violating the reset controller API.
--

commit 432f7b3656f374ab11511fbdd94e2169a520d3bc
Author: Joakim Zhang <joakim.zhang@cixtech.com>

reset: cix: add sky1 audss auxiliary reset driver

This patch adds an auxiliary reset controller driver for the Cix Sky1 AUDSS
CRU. It registers 16 software reset lines for audio peripherals that are
controlled through a single register.

> diff --git a/drivers/reset/reset-sky1-audss.c b/drivers/reset/reset-sky1-audss.c
> new file mode 100644
> index 0000000000000..20870f37d7d73
> --- /dev/null
> +++ b/drivers/reset/reset-sky1-audss.c

[ ... ]

> +static int sky1_audss_reset_set(struct reset_controller_dev *rcdev,
> +				unsigned long id, bool assert)
> +{
> +	struct sky1_audss_reset *priv = to_sky1_audss_reset(rcdev);
> +	const struct sky1_audss_reset_map *signal = &priv->map[id];
> +	unsigned int value = assert ? 0 : signal->mask;
> +
> +	return regmap_update_bits(priv->regmap, signal->offset, signal->mask, value);
> +}

[ ... ]

> +static int sky1_audss_reset_status(struct reset_controller_dev *rcdev,
> +				   unsigned long id)
> +{
> +	struct sky1_audss_reset *priv = to_sky1_audss_reset(rcdev);
> +	const struct sky1_audss_reset_map *signal = &priv->map[id];
> +	unsigned int value;
> +
> +	regmap_read(priv->regmap, signal->offset, &value);
> +	return !!(value & signal->mask);

[Severity: High]
Since sky1_audss_reset_set() establishes that the hardware uses active-low
logic by writing 0 when assert is true, does this status function return an
inverted result?

The reset controller API requires returning a positive value when the line
is asserted and zero when deasserted. Should the return statement be inverted
to !(value & signal->mask) to correctly report the asserted state?

> +}

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260623070805.211019-1-joakim.zhang@cixtech.com?part=3