Re: [PATCH V14 2/9] dt-bindings: iio: imu: icm42600: Add icm42607

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The new compatibles 'invensense,icm42607' and 'invensense,icm42607p' are omitted from the conditional block requiring the 'interrupts' property, violating Device Tree hardware description rules.
--

commit dfee2e713ee93b8822c465d8c4cace6a935bc62d
Author: Chris Morgan <macromorgan@hotmail.com>

dt-bindings: iio: imu: icm42600: Add icm42607

This commit adds the icm42607 and icm42607p inertial measurement unit device tree bindings. It also refactors the required properties to make the interrupts property conditional, explicitly omitting the newly added compatibles.

>     This device is functionally very similar to the icm42600 series with a
>     very different register layout. The driver does not require an
>     interrupt for these specific chip revisions.

[Severity: Medium]
Is it appropriate to omit the interrupts property based on driver behavior rather than hardware wiring?

Device tree bindings are meant to describe the hardware capabilities rather than specific operating system driver limitations. If the icm42607 hardware physically has an interrupt line, shouldn't it remain a required property regardless of whether the current driver uses it?

> diff --git a/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml b/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml
> index 9b2af104f186d..81b6e85decd52 100644
> --- a/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml
> +++ b/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml

[ ... ]

> @@ -67,10 +69,24 @@ properties:
>  required:
>    - compatible
>    - reg
> -  - interrupts
>  
>  allOf:
>    - $ref: /schemas/spi/spi-peripheral-props.yaml#
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - invensense,icm42600
> +              - invensense,icm42602
> +              - invensense,icm42605
> +              - invensense,icm42622
> +              - invensense,icm42631
> +              - invensense,icm42686
> +              - invensense,icm42688
> +    then:
> +      required:
> +        - interrupts

[Severity: Medium]
Does omitting the newly added compatibles from this enum block bypass device tree schema validation for those variants?

If the hardware shares the same interrupt constraints as the previous generations listed here, device trees missing the interrupts property for invensense,icm42607 will now silently pass validation.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260624182350.50467-1-macroalpha82@gmail.com?part=2