Re: [PATCH v5 04/12] dt-bindings: iio: dac: ad5686: rework on power supplies

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Critical] Unconditionally requiring `vdd-supply`, `vlogic-supply`, and `vref-supply` breaks device tree schema validation for existing, previously valid device trees.
--

commit 0fb515588de05f04b0a128cbc333f2b88d5550dd
Author: Rodrigo Alencar <rodrigo.alencar@analog.com>

dt-bindings: iio: dac: ad5686: rework on power supplies

This commit updates the device tree binding for the AD5686 DAC to add
supplies for VDD, VLOGIC, and VREF. It deprecates the vcc-supply
property in favor of vref-supply and marks vdd and vlogic supplies
as required for correct operation.

> diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml
> index d781baca6a6c2..02e8c78e36d3d 100644
> --- a/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml
> +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml

[ ... ]

> @@ -60,9 +74,23 @@ properties:
>  required:
>    - compatible
>    - reg
> +  - vdd-supply
> +  - vlogic-supply

[Severity: Critical]
Does unconditionally adding vdd-supply and vlogic-supply to the global
required list cause a regression for backward compatibility?

Existing device trees that successfully probed without these properties
will now fail dtbs_check validation.

Should newly introduced supply requirements remain optional to preserve
the Device Tree ABI?

>  
>  allOf:
>    - $ref: /schemas/spi/spi-peripheral-props.yaml#
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - adi,ad5676
> +              - adi,ad5683
> +              - adi,ad5684
> +              - adi,ad5686
> +    then:
> +      required:
> +        - vref-supply

[Severity: Critical]
By making vref-supply unconditionally required for these compatibles, does
this cause a validation regression for older device trees that legitimately
used the now-deprecated vcc-supply?

To transition away from vcc-supply without breaking existing device trees,
should the schema perhaps allow either vcc-supply or vref-supply to fulfill
the reference voltage requirement (e.g., via anyOf)?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260628-ad5686-new-features-v5-0-577caadbf7c0@analog.com?part=4