Re: [PATCH v5 02/12] dt-bindings: iio: dac: ad5696: rework on power supplies

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Schema enforces `vref-supply` without allowing the deprecated `vcc-supply` as a fallback, breaking validation of valid older Device Trees.
--

commit d1ea0994f3199f8070f6ba7242d274388ad08f50
Author: Rodrigo Alencar <rodrigo.alencar@analog.com>

dt-bindings: iio: dac: ad5696: rework on power supplies

This commit adds vdd, vlogic, and vref supplies to the ad5696 binding,
deprecates the misleading vcc-supply in favor of vref-supply, and makes
the new supplies required.

> diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5696.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5696.yaml
> index cc343cdf6085a..e10f8596f9d3f 100644
> --- a/Documentation/devicetree/bindings/iio/dac/adi,ad5696.yaml
> +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5696.yaml
[ ... ]
> @@ -62,8 +75,21 @@ properties:
>  required:
>    - compatible
>    - reg
> +  - vdd-supply
> +  - vlogic-supply

[Severity: Medium]
Does adding these directly to the global required list break dtbs_check for
existing Device Trees? Older device trees wouldn't have vdd-supply or
vlogic-supply defined, which would now fail validation.

>  
>  allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - adi,ad5693
> +              - adi,ad5694
> +              - adi,ad5696
> +    then:
> +      required:
> +        - vref-supply

[Severity: Medium]
Will this block reject valid legacy device trees that still use the now
deprecated vcc-supply?

When replacing a property, the schema typically needs to accept both the old
and new properties to maintain backward compatibility for existing trees,
for instance by using anyOf to allow either vref-supply or vcc-supply to
satisfy the requirement.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260628-ad5686-new-features-v5-0-577caadbf7c0@analog.com?part=2