Devicetree
 help / color / mirror / Atom feed
From: Jason Pettit <jason.pettit@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Jason Pettit <jason.pettit@oss.qualcomm.com>,
	Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Akhil P Oommen <akhilpo@oss.qualcomm.com>,
	Mahadevan P <mahadevan.p@oss.qualcomm.com>,
	Sibi Sankar <sibi.sankar@oss.qualcomm.com>,
	Jingyi Wang <jingyi.wang@oss.qualcomm.com>,
	Ananthu C V <ananthu.cv@oss.qualcomm.com>
Subject: Re: [PATCH v2 2/3] arm64: dts: qcom: Add HP EliteBook X G2q 14 AI
Date: Sun, 28 Jun 2026 09:29:13 -0700	[thread overview]
Message-ID: <20260628162913.66306-1-jason.pettit@oss.qualcomm.com> (raw)
In-Reply-To: <e7bal26fyufjh2f4j6rh57bcdvubp3qqydk4pjagq3qjdz3ywz@wtfsiff726zx>

On Sun, 28 Jun 2026 16:02:24 +0300, Dmitry Baryshkov wrote:
> This is very surprising. Can you check, is it actually the DWC3 or is it
> some power supply that is being toggled by the USB controller? In the
> former case it would mean that we miss some bits of PHY programming and
> still depend on the USB host / USB part of the PHY.

I tried to check this. I am fairly new to this, so I mostly poked at it on
the hardware. Here is what I did and what I saw, and you can probably read
more into it than I can.

1. First, with &usb_2 (the dwc3, HS-only) and &usb_2_hsphy enabled, HDMI
   works. I looked at the power state on that boot to see if the dwc3 turns
   on anything the DP side might also need. As far as I can tell they are
   separate. The combo PHY, the dwc3, and the DP controller are each in a
   different power domain, and the PHY's regulators show up under the PHY,
   not the dwc3:

     gcc_usb_2_phy_gdsc    on
         88e1000.phy                       active   (the combo PHY)
     gcc_usb30_tert_gdsc   on
         a000000.usb                       active   (the dwc3)
     mmcx                  on
         af64000.displayport-controller    active   (mdss_dp2)

     vreg_l2f_e0_0p94 -> 88e1000.phy-refgen
     vreg_l3f_e0_0p91 -> 88e1000.phy-vdda-pll
     vreg_l4h_e0_1p2  -> 88e1000.phy-vdda-phy

   So I did not find a rail or GDSC that the dwc3 owns and the PHY needs.

2. Then I removed &usb_2 and &usb_2_hsphy, rebuilt, and rebooted. mdss_dp2
   still binds:

     msm_dpu ae01000.display-controller: bound af64000.displayport-controller

   and HDMI-A-1 still reads connected, so the PHY seems powered and the AUX
   side is working, but there is no picture on the monitor.

3. Putting the two nodes back makes the picture come back, and the PHY's
   supplies look the same either way.

So from what I can see the power is not the thing being toggled. The PHY
stays powered without the dwc3, but DP still has no image. That seems to
line up with your first option, that something on the USB side of the PHY
still has to be brought up.

For now I have kept the dwc3 enabled as a workaround. If this is a driver
issue and someone has a fix or a pointer, I am happy to test it on the
hardware.

Thanks,
Jason

  reply	other threads:[~2026-06-28 16:29 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-26  5:47 [PATCH v2 0/3] X2 Elite HP EliteBook X G2q support Jason Pettit
2026-06-26  5:47 ` [PATCH v2 1/3] dt-bindings: arm: qcom: Add HP EliteBook X G2q 14 AI Jason Pettit
2026-06-26 10:20   ` Krzysztof Kozlowski
2026-06-26  5:47 ` [PATCH v2 2/3] arm64: dts: " Jason Pettit
2026-06-26  6:00   ` sashiko-bot
2026-06-26 11:26   ` Konrad Dybcio
2026-06-27 18:55     ` t
2026-06-27 19:06     ` Jason Pettit
2026-06-29  9:27       ` Konrad Dybcio
2026-06-26 11:27   ` Konrad Dybcio
2026-06-27 18:55     ` t
2026-06-27 19:06     ` Jason Pettit
2026-06-28 13:02       ` Dmitry Baryshkov
2026-06-28 16:29         ` Jason Pettit [this message]
2026-06-29  9:47           ` Konrad Dybcio
2026-06-29 14:19             ` Jason Pettit
2026-06-30 11:04               ` Konrad Dybcio
2026-06-26  5:47 ` [PATCH v2 3/3] firmware: qcom: scm: Allow QSEECOM on " Jason Pettit
2026-06-28 13:02   ` Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260628162913.66306-1-jason.pettit@oss.qualcomm.com \
    --to=jason.pettit@oss.qualcomm.com \
    --cc=akhilpo@oss.qualcomm.com \
    --cc=ananthu.cv@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=jingyi.wang@oss.qualcomm.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mahadevan.p@oss.qualcomm.com \
    --cc=robh@kernel.org \
    --cc=sibi.sankar@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox