Re: Re: Re: Re: [PATCH 3/7] riscv: dts: eswin: eic7700: add pinctrl support

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1053 bytes --]

On Mon, Jun 29, 2026 at 05:40:00PM +0800, Yulin Lu wrote:
> &gpio1_pins {       /* jtag0_tck repurposed as GPIO input */
> 	bias-disable;
> 	input-enable;
> };
> 
> &gpio2_pins {       /* jtag0_tms repurposed as GPIO output */
> 	bias-disable;
> 	input-disable;
> };
> 
> If we merge them into a single node, a board DTS can only apply one
> configuration to all 4 pins simultaneously:
> 
> &gpio_jtag_pins {
> 	bias-disable;
> 	input-enable;   /* forced onto all 4 pins - no per-pin control */
> };  

Okay, I didn't notice this, sorry.

> 
> This removes the ability for board DTS files to independently configure
> the electrical properties of each pin when they are used as GPIO for
> different purposes.
> 
> We will send a v2 that also fixes two bugs introduced in this patch:
> rgmii0_pins and rgmii1_pins incorrectly specify function = "hdmi"
> instead of "rgmii", and i2s0_pins, i2s1_pins, i2s2_pins specify
> function = "hdmi" instead of "i2s". These would cause the mux
> requests to fail at runtime. 

Sure.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]