[PATCH 1/2] Bluetooth: hci_bcm: add BCM43752

[PATCH 1/2] Bluetooth: hci_bcm: add BCM43752

[Hugo Osvaldo Barrera]

Add the compatible for BCM43752 used in Fydetab Duo.

Signed-off-by: Hugo Osvaldo Barrera <hugo@whynothugo.nl>
---
 drivers/bluetooth/hci_bcm.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c
index 1a4fc3882fd2..443969afa747 100644
--- a/drivers/bluetooth/hci_bcm.c
+++ b/drivers/bluetooth/hci_bcm.c
@@ -1591,6 +1591,7 @@ static const struct of_device_id bcm_bluetooth_of_match[] = {
 	{ .compatible = "brcm,bcm43438-bt", .data = &bcm43438_device_data },
 	{ .compatible = "brcm,bcm4349-bt", .data = &bcm43438_device_data },
 	{ .compatible = "brcm,bcm43540-bt", .data = &bcm4354_device_data },
+	{ .compatible = "brcm,bcm43752-bt" },
 	{ .compatible = "brcm,bcm4335a0" },
 	{ .compatible = "cypress,cyw4373a0-bt", .data = &cyw4373a0_device_data },
 	{ .compatible = "infineon,cyw55572-bt", .data = &cyw55572_device_data },
-- 
2.54.0

[PATCH 2/2] dt-bindings: bluetooth: broadcom: add BCM43752

[Hugo Osvaldo Barrera]

Document the compatible string for BCM43752.

Signed-off-by: Hugo Osvaldo Barrera <hugo@whynothugo.nl>
---
 .../devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml        | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml
index 95501e858e6f..04e8a968548d 100644
--- a/Documentation/devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml
+++ b/Documentation/devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml
@@ -29,6 +29,7 @@ properties:
           - brcm,bcm43438-bt
           - brcm,bcm4345c5
           - brcm,bcm43540-bt
+          - brcm,bcm43752-bt
           - brcm,bcm4335a0
           - brcm,bcm4349-bt
           - cypress,cyw4373a0-bt
-- 
2.54.0

Re: [PATCH 2/2] dt-bindings: bluetooth: broadcom: add BCM43752

[Hugo Osvaldo Barrera]

On Sun, 28 Jun 2026, at 13:57, bluez.test.bot@gmail.com wrote:
> […]
> ##############################
> Test: SubjectPrefix - FAIL
> Desc: Check subject contains "Bluetooth" prefix
> Output:
> "Bluetooth: " prefix is not specified in the subject

I followed the style of previous patches introducing
similar changes to this same file. Should I include
this prefix for this patch too?

> ##############################
> Test: TestRunner_mgmt-tester - FAIL
> Desc: Run mgmt-tester with test-runner
> Output:
> Total: 494, Passed: 489 (99.0%), Failed: 1, Not Run: 4
>
> Failed Test Cases
> Read Exp Feature - Success                           Failed       0.257 seconds

I can't find any reference of "mgmt-tester" anywhere
in the repo. Is this failure unrelated to my changes?

-- 
Hugo

Re: [PATCH 2/2] dt-bindings: bluetooth: broadcom: add BCM43752

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1002 bytes --]

On Sun, Jun 28, 2026 at 06:49:13PM +0200, Hugo Osvaldo Barrera wrote:
> On Sun, 28 Jun 2026, at 13:57, bluez.test.bot@gmail.com wrote:
> > […]
> > ##############################
> > Test: SubjectPrefix - FAIL
> > Desc: Check subject contains "Bluetooth" prefix
> > Output:
> > "Bluetooth: " prefix is not specified in the subject
> 
> I followed the style of previous patches introducing
> similar changes to this same file. Should I include
> this prefix for this patch too?
> 
> > ##############################
> > Test: TestRunner_mgmt-tester - FAIL
> > Desc: Run mgmt-tester with test-runner
> > Output:
> > Total: 494, Passed: 489 (99.0%), Failed: 1, Not Run: 4
> >
> > Failed Test Cases
> > Read Exp Feature - Success                           Failed       0.257 seconds
> 
> I can't find any reference of "mgmt-tester" anywhere
> in the repo. Is this failure unrelated to my changes?

No idea what this is, but it's unlikely to be anything to do with a
dt-binding.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH 2/2] dt-bindings: bluetooth: broadcom: add BCM43752

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1051 bytes --]

On Sun, Jun 28, 2026 at 11:55:00AM +0200, Hugo Osvaldo Barrera wrote:
> Document the compatible string for BCM43752.
> 
> Signed-off-by: Hugo Osvaldo Barrera <hugo@whynothugo.nl>
> ---
>  .../devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml        | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml
> index 95501e858e6f..04e8a968548d 100644
> --- a/Documentation/devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml
> +++ b/Documentation/devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml
> @@ -29,6 +29,7 @@ properties:
>            - brcm,bcm43438-bt
>            - brcm,bcm4345c5
>            - brcm,bcm43540-bt
> +          - brcm,bcm43752-bt

This new compatible uses no match data. Why is a fallback compatible not
suitable?

Thanks,
Conor.

>            - brcm,bcm4335a0
>            - brcm,bcm4349-bt
>            - cypress,cyw4373a0-bt
> -- 
> 2.54.0
> 
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH 2/2] dt-bindings: bluetooth: broadcom: add BCM43752

[Hugo Osvaldo Barrera]

On Sun, 28 Jun 2026, at 21:17, Conor Dooley wrote:
> On Sun, Jun 28, 2026 at 11:55:00AM +0200, Hugo Osvaldo Barrera wrote:
>> Document the compatible string for BCM43752.
>> 
>> Signed-off-by: Hugo Osvaldo Barrera <hugo@whynothugo.nl>
>> ---
>>  .../devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml        | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/Documentation/devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml
>> index 95501e858e6f..04e8a968548d 100644
>> --- a/Documentation/devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml
>> +++ b/Documentation/devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml
>> @@ -29,6 +29,7 @@ properties:
>>            - brcm,bcm43438-bt
>>            - brcm,bcm4345c5
>>            - brcm,bcm43540-bt
>> +          - brcm,bcm43752-bt
>
> This new compatible uses no match data. Why is a fallback compatible not
> suitable?
>

I wasn't aware that this was the preferred approach.

I used `compatible = "brcm,bcm43752-bt", "brcm,bcm43430a0-bt";`
in my DT and Bluetooth works equally well. Both of these patches
can be ignored, thanks for the review.

There are multiple compatible with no match data, and I was
mostly following that approach. Are they there mostly for
legacy reasons and adding more with no match data is discouraged?
Or am I missing something else?

Thanks,

-- 
Hugo

Re: [PATCH 2/2] dt-bindings: bluetooth: broadcom: add BCM43752

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1681 bytes --]

On Mon, Jun 29, 2026 at 01:32:18PM +0200, Hugo Osvaldo Barrera wrote:
> 
> 
> On Sun, 28 Jun 2026, at 21:17, Conor Dooley wrote:
> > On Sun, Jun 28, 2026 at 11:55:00AM +0200, Hugo Osvaldo Barrera wrote:
> >> Document the compatible string for BCM43752.
> >> 
> >> Signed-off-by: Hugo Osvaldo Barrera <hugo@whynothugo.nl>
> >> ---
> >>  .../devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml        | 1 +
> >>  1 file changed, 1 insertion(+)
> >> 
> >> diff --git a/Documentation/devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml
> >> index 95501e858e6f..04e8a968548d 100644
> >> --- a/Documentation/devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml
> >> +++ b/Documentation/devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml
> >> @@ -29,6 +29,7 @@ properties:
> >>            - brcm,bcm43438-bt
> >>            - brcm,bcm4345c5
> >>            - brcm,bcm43540-bt
> >> +          - brcm,bcm43752-bt
> >
> > This new compatible uses no match data. Why is a fallback compatible not
> > suitable?
> >
> 
> I wasn't aware that this was the preferred approach.
> 
> I used `compatible = "brcm,bcm43752-bt", "brcm,bcm43430a0-bt";`
> in my DT and Bluetooth works equally well. Both of these patches
> can be ignored, thanks for the review.

You still need to add a binding patch to document the new compatible,
just it will permit the fallback.

> There are multiple compatible with no match data, and I was
> mostly following that approach. Are they there mostly for
> legacy reasons and adding more with no match data is discouraged?

Correct.

Cheers,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH 2/2] dt-bindings: bluetooth: broadcom: add BCM43752

[Hugo Osvaldo Barrera]

On Mon, 29 Jun 2026, at 14:04, Conor Dooley wrote:
> On Mon, Jun 29, 2026 at 01:32:18PM +0200, Hugo Osvaldo Barrera wrote:
>> 
>> 
>> On Sun, 28 Jun 2026, at 21:17, Conor Dooley wrote:
>> > On Sun, Jun 28, 2026 at 11:55:00AM +0200, Hugo Osvaldo Barrera wrote:
>> >> Document the compatible string for BCM43752.
>> >> 
>> >> Signed-off-by: Hugo Osvaldo Barrera <hugo@whynothugo.nl>
>> >> ---
>> >>  .../devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml        | 1 +
>> >>  1 file changed, 1 insertion(+)
>> >> 
>> >> diff --git a/Documentation/devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml
>> >> index 95501e858e6f..04e8a968548d 100644
>> >> --- a/Documentation/devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml
>> >> +++ b/Documentation/devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml
>> >> @@ -29,6 +29,7 @@ properties:
>> >>            - brcm,bcm43438-bt
>> >>            - brcm,bcm4345c5
>> >>            - brcm,bcm43540-bt
>> >> +          - brcm,bcm43752-bt
>> >
>> > This new compatible uses no match data. Why is a fallback compatible not
>> > suitable?
>> >
>> 
>> I wasn't aware that this was the preferred approach.
>> 
>> I used `compatible = "brcm,bcm43752-bt", "brcm,bcm43430a0-bt";`
>> in my DT and Bluetooth works equally well. Both of these patches
>> can be ignored, thanks for the review.
>
> You still need to add a binding patch to document the new compatible,
> just it will permit the fallback.
>

Right, CHECK_DTBS=y fails without that change.
So the second patch (which changes brcm,bluetooth.yaml) should be merged,
but not the other one is unnecessary and can be ignored.

I don't need to re-submit the second path independently, it's fine to
just merge one patch and ignore the other, right?

-- 
Hugo

Re: [PATCH 2/2] dt-bindings: bluetooth: broadcom: add BCM43752

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 2215 bytes --]

On Mon, Jun 29, 2026 at 06:57:17PM +0200, Hugo Osvaldo Barrera wrote:
> 
> 
> On Mon, 29 Jun 2026, at 14:04, Conor Dooley wrote:
> > On Mon, Jun 29, 2026 at 01:32:18PM +0200, Hugo Osvaldo Barrera wrote:
> >> 
> >> 
> >> On Sun, 28 Jun 2026, at 21:17, Conor Dooley wrote:
> >> > On Sun, Jun 28, 2026 at 11:55:00AM +0200, Hugo Osvaldo Barrera wrote:
> >> >> Document the compatible string for BCM43752.
> >> >> 
> >> >> Signed-off-by: Hugo Osvaldo Barrera <hugo@whynothugo.nl>
> >> >> ---
> >> >>  .../devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml        | 1 +
> >> >>  1 file changed, 1 insertion(+)
> >> >> 
> >> >> diff --git a/Documentation/devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml
> >> >> index 95501e858e6f..04e8a968548d 100644
> >> >> --- a/Documentation/devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml
> >> >> +++ b/Documentation/devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml
> >> >> @@ -29,6 +29,7 @@ properties:
> >> >>            - brcm,bcm43438-bt
> >> >>            - brcm,bcm4345c5
> >> >>            - brcm,bcm43540-bt
> >> >> +          - brcm,bcm43752-bt
> >> >
> >> > This new compatible uses no match data. Why is a fallback compatible not
> >> > suitable?
> >> >
> >> 
> >> I wasn't aware that this was the preferred approach.
> >> 
> >> I used `compatible = "brcm,bcm43752-bt", "brcm,bcm43430a0-bt";`
> >> in my DT and Bluetooth works equally well. Both of these patches
> >> can be ignored, thanks for the review.
> >
> > You still need to add a binding patch to document the new compatible,
> > just it will permit the fallback.
> >
> 
> Right, CHECK_DTBS=y fails without that change.
> So the second patch (which changes brcm,bluetooth.yaml) should be merged,
> but not the other one is unnecessary and can be ignored.
> 
> I don't need to re-submit the second path independently, it's fine to
> just merge one patch and ignore the other, right?

You need to submit a v2 of this patch, because the compatible setup you
tested and pasted above is not permitted by the current binding. The
driver patch becomes redundant.

Thanks,
Conor

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]