Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Icenowy Zheng" <zhengxingda@iscas.ac.cn>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org,
	dri-devel@lists.freedesktop.org, robh@kernel.org
Subject: Re: [PATCH] dt-bindings: display: verisilicon,dc: make resets non-optional
Date: Mon, 29 Jun 2026 05:35:33 +0000	[thread overview]
Message-ID: <20260629053600.336811F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260629053017.4050868-1-zhengxingda@iscas.ac.cn>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit message incorrectly states that the controller requires 'two reset lines', while the actual binding schema and examples define three reset lines ('core', 'axi', 'ahb').
--

commit 11712ddd9a2861c41656c6eb9cdbd525c93e3665
Author: Icenowy Zheng <zhengxingda@iscas.ac.cn>

dt-bindings: display: verisilicon, dc: make resets non-optional

This commit makes the resets and reset-names properties mandatory for the
DC8200 controller variant. The commit message notes that the in-tree
device tree already populates these lines and the driver handles them
gracefully if missing in other variants.

> The only variant supported by the binding now, the DC8200 controller on
> T-Head TH1520, requires two reset lines.

[Severity: Low]
Is the description of "two reset lines" accurate here? 

Looking at the existing schema in verisilicon,dc.yaml under the resets
property, it defines three reset items (DC Core reset, DMA AXI bus reset,
and Configuration AHB bus reset). Should the commit message mention three
resets instead of two?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260629053017.4050868-1-zhengxingda@iscas.ac.cn?part=1

  reply	other threads:[~2026-06-29  5:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-29  5:30 [PATCH] dt-bindings: display: verisilicon,dc: make resets non-optional Icenowy Zheng
2026-06-29  5:35 ` sashiko-bot [this message]
2026-06-29  5:47   ` Icenowy Zheng
2026-06-29 15:28 ` Conor Dooley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260629053600.336811F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=zhengxingda@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox