[PATCH] dt-bindings: display: verisilicon,dc: make resets non-optional

[PATCH] dt-bindings: display: verisilicon,dc: make resets non-optional

[Icenowy Zheng]

The only variant supported by the binding now, the DC8200 controller on
T-Head TH1520, requires two reset lines.

Add the reset properties to the required list to clarify this. The
in-tree th1520.dtsi file isn't affected by this change because the reset
lines are already populated there.

The driver still considers the resets optional, so if another variant
with no reset line appears, only the binding needs tweaking.

Signed-off-by: Icenowy Zheng <zhengxingda@iscas.ac.cn>
---
 Documentation/devicetree/bindings/display/verisilicon,dc.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/verisilicon,dc.yaml b/Documentation/devicetree/bindings/display/verisilicon,dc.yaml
index 9dc35ab973f20..919a900122012 100644
--- a/Documentation/devicetree/bindings/display/verisilicon,dc.yaml
+++ b/Documentation/devicetree/bindings/display/verisilicon,dc.yaml
@@ -75,6 +75,8 @@ required:
   - interrupts
   - clocks
   - clock-names
+  - resets
+  - reset-names
   - ports
 
 additionalProperties: false
-- 
2.52.0

Re: [PATCH] dt-bindings: display: verisilicon,dc: make resets non-optional

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit message incorrectly states that the controller requires 'two reset lines', while the actual binding schema and examples define three reset lines ('core', 'axi', 'ahb').
--

commit 11712ddd9a2861c41656c6eb9cdbd525c93e3665
Author: Icenowy Zheng <zhengxingda@iscas.ac.cn>

dt-bindings: display: verisilicon, dc: make resets non-optional

This commit makes the resets and reset-names properties mandatory for the
DC8200 controller variant. The commit message notes that the in-tree
device tree already populates these lines and the driver handles them
gracefully if missing in other variants.

> The only variant supported by the binding now, the DC8200 controller on
> T-Head TH1520, requires two reset lines.

[Severity: Low]
Is the description of "two reset lines" accurate here? 

Looking at the existing schema in verisilicon,dc.yaml under the resets
property, it defines three reset items (DC Core reset, DMA AXI bus reset,
and Configuration AHB bus reset). Should the commit message mention three
resets instead of two?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260629053017.4050868-1-zhengxingda@iscas.ac.cn?part=1

Re: [PATCH] dt-bindings: display: verisilicon,dc: make resets non-optional

[Icenowy Zheng]

在 2026-06-29一的 05:35 +0000，sashiko-bot@kernel.org写道：
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue(s) to consider:
> - [Low] The commit message incorrectly states that the controller
> requires 'two reset lines', while the actual binding schema and
> examples define three reset lines ('core', 'axi', 'ahb').
> --
> 
> commit 11712ddd9a2861c41656c6eb9cdbd525c93e3665
> Author: Icenowy Zheng <zhengxingda@iscas.ac.cn>
> 
> dt-bindings: display: verisilicon, dc: make resets non-optional
> 
> This commit makes the resets and reset-names properties mandatory for
> the
> DC8200 controller variant. The commit message notes that the in-tree
> device tree already populates these lines and the driver handles them
> gracefully if missing in other variants.
> 
> > The only variant supported by the binding now, the DC8200
> > controller on
> > T-Head TH1520, requires two reset lines.
> 
> [Severity: Low]
> Is the description of "two reset lines" accurate here? 
> 
> Looking at the existing schema in verisilicon,dc.yaml under the
> resets
> property, it defines three reset items (DC Core reset, DMA AXI bus
> reset,
> and Configuration AHB bus reset). Should the commit message mention
> three
> resets instead of two?

Thanks for this tip, it seems that my memory in brain bitfilpped and
this deserves a fix.

Thanks,
Icenowy

Re: [PATCH] dt-bindings: display: verisilicon,dc: make resets non-optional

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1324 bytes --]

On Mon, Jun 29, 2026 at 01:30:17PM +0800, Icenowy Zheng wrote:
> The only variant supported by the binding now, the DC8200 controller on
> T-Head TH1520, requires two reset lines.
> 
> Add the reset properties to the required list to clarify this. The
> in-tree th1520.dtsi file isn't affected by this change because the reset
> lines are already populated there.
> 
> The driver still considers the resets optional, so if another variant
> with no reset line appears, only the binding needs tweaking.
> 

Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

pw-bot: changes-requested
(cos of sashiko)
> Signed-off-by: Icenowy Zheng <zhengxingda@iscas.ac.cn>
> ---
>  Documentation/devicetree/bindings/display/verisilicon,dc.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/verisilicon,dc.yaml b/Documentation/devicetree/bindings/display/verisilicon,dc.yaml
> index 9dc35ab973f20..919a900122012 100644
> --- a/Documentation/devicetree/bindings/display/verisilicon,dc.yaml
> +++ b/Documentation/devicetree/bindings/display/verisilicon,dc.yaml
> @@ -75,6 +75,8 @@ required:
>    - interrupts
>    - clocks
>    - clock-names
> +  - resets
> +  - reset-names
>    - ports
>  
>  additionalProperties: false
> -- 
> 2.52.0
> 
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]