Re: [PATCH 1/2] dt-bindings: memory: Add TI FSS_FSAS binding

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `$id` field in the YAML binding schema does not match the file's location, which breaks schema cross-referencing and can cause `dt_binding_check` to silently skip validation.
--

commit 54d35a3fdeae166603662fbdb3cac4a24e6c37c1
Author: Santhosh Kumar K <s-k6@ti.com>

dt-bindings: memory: Add TI FSS_FSAS binding

This commit adds a device tree binding for the TI Flash Subsystem
Application Subsystem (FSS_FSAS_GENREGS) wrapper. This wrapper block
is present in TI K3 SoCs and controls XIP read prefetch for the OSPI
controller.

> diff --git a/Documentation/devicetree/bindings/memory-controllers/ti,am62a-fsas.yaml b/Documentation/devicetree/bindings/memory-controllers/ti,am62a-fsas.yaml
> new file mode 100644
> index 0000000000000..81c71ebfb7e13
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/memory-controllers/ti,am62a-fsas.yaml
> @@ -0,0 +1,39 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (C) 2025 Texas Instruments Incorporated
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/ti/ti,am62a-fsas.yaml#

[Severity: Medium]
Does this $id path mismatch the file's actual location?

The file is being added to the memory-controllers subdirectory, but the
$id field specifies soc/ti/. When the $id field does not exactly match
the file path relative to Documentation/devicetree/bindings/, it breaks
schema cross-referencing and can cause dt_binding_check to silently skip
validation or report misleading errors.

> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments K3 Flash SubSystem Application Subsystem (FSS_FSAS)

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260629064228.860226-1-s-k6@ti.com?part=1