Re: [PATCH 2/2] memory: ti-k3-fsas: Add TI FSS_FSAS driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incorrect wrapper macro `pm_sleep_ptr()` used for the `dev_pm_ops` structure pointer.
--

commit be06c2a7e885af5ffba7e5ddc137bd7ba0758747
Author: Santhosh Kumar K <s-k6@ti.com>
memory: ti-k3-fsas: Add TI FSS_FSAS driver

This commit adds a new platform driver for the TI K3 Flash Subsystem
Application Subsystem (FSS_FSAS). It configures the SYSCONFIG register to
disable OSPI XIP prefetch, preventing DMA data corruption.

> diff --git a/drivers/memory/ti-k3-fsas.c b/drivers/memory/ti-k3-fsas.c
> new file mode 100644
> index 0000000000000..9ff109b8d96fd
> --- /dev/null
> +++ b/drivers/memory/ti-k3-fsas.c
[ ... ]
> +static DEFINE_SIMPLE_DEV_PM_OPS(k3_fsas_pm_ops, NULL, k3_fsas_resume);
> +
> +static const struct of_device_id k3_fsas_of_match[] = {
> +	{ .compatible = "ti,am62a-fsas" },
> +	{ /* sentinel */ }
> +};
> +MODULE_DEVICE_TABLE(of, k3_fsas_of_match);
> +
> +static struct platform_driver k3_fsas_driver = {
> +	.probe = k3_fsas_probe,
> +	.driver = {
> +		.name		= "k3-fsas",
> +		.of_match_table	= k3_fsas_of_match,
> +		.pm		= pm_sleep_ptr(&k3_fsas_pm_ops),

[Severity: Low]
Should this use pm_ptr() instead of pm_sleep_ptr() for the dev_pm_ops
structure pointer?

The PM subsystem guidelines specify that pm_sleep_ptr() is intended for the
individual sleep callbacks, while pm_ptr() should be used for the dev_pm_ops
structure pointer itself. While this doesn't cause immediate issues since
the driver currently only uses sleep callbacks, using pm_ptr() here ensures
consistency with standard PM usage and prevents issues if runtime PM
callbacks are added later.

> +	},
> +};
> +module_platform_driver(k3_fsas_driver);

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260629064228.860226-1-s-k6@ti.com?part=2