Re: [PATCH v2] dt-bindings: arm-smmu: qcom: Add compatible for Maili SoC

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The new compatible string `qcom,maili-smmu-500` was added to the main list but omitted from the `allOf` conditional block that disallows clocks.
--

commit 5d07ecfd0f829393f9b6baedb17d072c42c1deab
Author: Jingyi Wang <jingyi.wang@oss.qualcomm.com>

dt-bindings: arm-smmu: qcom: Add compatible for Maili SoC
    
Qualcomm Maili SoC includes apps smmu that implements arm,mmu-500,
which is used to translate device-visible virtual addresses to
physical addresses. Add compatible for it.

> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
> index a701dec2fa0a4..c48e9de1a2bd5 100644
> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
> @@ -39,6 +39,7 @@ properties:
>                - qcom,glymur-smmu-500
>                - qcom,hawi-smmu-500
>                - qcom,kaanapali-smmu-500
> +              - qcom,maili-smmu-500
               ^^^^^^^^^^^^^^^^^^^^^^^

[Severity: Low]
Does the new compatible string also need to be added to the allOf conditional
block that disallows clocks?

When qcom,maili-smmu-500 is missing from the conditional block that matches
other similar platforms:

  - if:
      properties:
        compatible:
          items:
            - enum:
                - qcom,eliza-smmu-500
                [ ... ]
                - qcom,kaanapali-smmu-500
            - const: qcom,smmu-500
            - const: arm,mmu-500
    then:
      properties:
        clock-names: false
        clocks: false

Device trees defining qcom,maili-smmu-500 that incorrectly include clocks
might silently pass schema validation during dt_binding_check.

>                - qcom,milos-smmu-500
>                - qcom,nord-smmu-500
>                - qcom,qcm2290-smmu-500

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260628-maili-smmu-v2-1-87448a7678ec@oss.qualcomm.com?part=1