[PATCH v2] dt-bindings: arm-smmu: qcom: Add compatible for Maili SoC

[PATCH v2] dt-bindings: arm-smmu: qcom: Add compatible for Maili SoC

[Jingyi Wang]

Qualcomm Maili SoC includes apps smmu that implements arm,mmu-500,
which is used to translate device-visible virtual addresses to
physical addresses. Add compatible for it.

Signed-off-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
---
Changes in v2:
- patch rebase
- Link to v1: https://lore.kernel.org/r/20260524-maili-smmu-v1-1-ec85b12fda83@oss.qualcomm.com
---
 Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
index a701dec2fa0a..c48e9de1a2bd 100644
--- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
+++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
@@ -39,6 +39,7 @@ properties:
               - qcom,glymur-smmu-500
               - qcom,hawi-smmu-500
               - qcom,kaanapali-smmu-500
+              - qcom,maili-smmu-500
               - qcom,milos-smmu-500
               - qcom,nord-smmu-500
               - qcom,qcm2290-smmu-500

---
base-commit: 3d5670d672ae08b8c534b7beed6f57c8b44e7b43
change-id: 20260628-maili-smmu-9ed0f2c189ad

Best regards,
-- 
Jingyi Wang <jingyi.wang@oss.qualcomm.com>

Re: [PATCH v2] dt-bindings: arm-smmu: qcom: Add compatible for Maili SoC

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The new compatible string `qcom,maili-smmu-500` was added to the main list but omitted from the `allOf` conditional block that disallows clocks.
--

commit 5d07ecfd0f829393f9b6baedb17d072c42c1deab
Author: Jingyi Wang <jingyi.wang@oss.qualcomm.com>

dt-bindings: arm-smmu: qcom: Add compatible for Maili SoC
    
Qualcomm Maili SoC includes apps smmu that implements arm,mmu-500,
which is used to translate device-visible virtual addresses to
physical addresses. Add compatible for it.

> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
> index a701dec2fa0a4..c48e9de1a2bd5 100644
> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
> @@ -39,6 +39,7 @@ properties:
>                - qcom,glymur-smmu-500
>                - qcom,hawi-smmu-500
>                - qcom,kaanapali-smmu-500
> +              - qcom,maili-smmu-500
               ^^^^^^^^^^^^^^^^^^^^^^^

[Severity: Low]
Does the new compatible string also need to be added to the allOf conditional
block that disallows clocks?

When qcom,maili-smmu-500 is missing from the conditional block that matches
other similar platforms:

  - if:
      properties:
        compatible:
          items:
            - enum:
                - qcom,eliza-smmu-500
                [ ... ]
                - qcom,kaanapali-smmu-500
            - const: qcom,smmu-500
            - const: arm,mmu-500
    then:
      properties:
        clock-names: false
        clocks: false

Device trees defining qcom,maili-smmu-500 that incorrectly include clocks
might silently pass schema validation during dt_binding_check.

>                - qcom,milos-smmu-500
>                - qcom,nord-smmu-500
>                - qcom,qcm2290-smmu-500

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260628-maili-smmu-v2-1-87448a7678ec@oss.qualcomm.com?part=1

Re: [PATCH v2] dt-bindings: arm-smmu: qcom: Add compatible for Maili SoC

[Jingyi Wang]

On 6/29/2026 3:03 PM, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] The new compatible string `qcom,maili-smmu-500` was added to the main list but omitted from the `allOf` conditional block that disallows clocks.
> --
> 
> commit 5d07ecfd0f829393f9b6baedb17d072c42c1deab
> Author: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
> 
> dt-bindings: arm-smmu: qcom: Add compatible for Maili SoC
>      
> Qualcomm Maili SoC includes apps smmu that implements arm,mmu-500,
> which is used to translate device-visible virtual addresses to
> physical addresses. Add compatible for it.
> 
>> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
>> index a701dec2fa0a4..c48e9de1a2bd5 100644
>> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
>> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
>> @@ -39,6 +39,7 @@ properties:
>>                 - qcom,glymur-smmu-500
>>                 - qcom,hawi-smmu-500
>>                 - qcom,kaanapali-smmu-500
>> +              - qcom,maili-smmu-500
>                 ^^^^^^^^^^^^^^^^^^^^^^^
> 
> [Severity: Low]
> Does the new compatible string also need to be added to the allOf conditional
> block that disallows clocks?
> 

No, we should not do that, it will conflict with the following up gpu smmu binding
that fallbacks to "qcom,adreno-smmu" and requires clock.

Thanks,
Jingyi

> When qcom,maili-smmu-500 is missing from the conditional block that matches
> other similar platforms:
> 
>    - if:
>        properties:
>          compatible:
>            items:
>              - enum:
>                  - qcom,eliza-smmu-500
>                  [ ... ]
>                  - qcom,kaanapali-smmu-500
>              - const: qcom,smmu-500
>              - const: arm,mmu-500
>      then:
>        properties:
>          clock-names: false
>          clocks: false
> 
> Device trees defining qcom,maili-smmu-500 that incorrectly include clocks
> might silently pass schema validation during dt_binding_check.
> 
>>                 - qcom,milos-smmu-500
>>                 - qcom,nord-smmu-500
>>                 - qcom,qcm2290-smmu-500
> 

Re: [PATCH v2] dt-bindings: arm-smmu: qcom: Add compatible for Maili SoC

[Jingyi Wang]

On 7/3/2026 3:40 PM, Jingyi Wang wrote:
> 
> 
> On 6/29/2026 3:03 PM, sashiko-bot@kernel.org wrote:
>> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
>> - [Low] The new compatible string `qcom,maili-smmu-500` was added to the main list but omitted from the `allOf` conditional block that disallows clocks.
>> -- 
>>
>> commit 5d07ecfd0f829393f9b6baedb17d072c42c1deab
>> Author: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
>>
>> dt-bindings: arm-smmu: qcom: Add compatible for Maili SoC
>> Qualcomm Maili SoC includes apps smmu that implements arm,mmu-500,
>> which is used to translate device-visible virtual addresses to
>> physical addresses. Add compatible for it.
>>
>>> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
>>> index a701dec2fa0a4..c48e9de1a2bd5 100644
>>> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
>>> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
>>> @@ -39,6 +39,7 @@ properties:
>>>                 - qcom,glymur-smmu-500
>>>                 - qcom,hawi-smmu-500
>>>                 - qcom,kaanapali-smmu-500
>>> +              - qcom,maili-smmu-500
>>                 ^^^^^^^^^^^^^^^^^^^^^^^
>>
>> [Severity: Low]
>> Does the new compatible string also need to be added to the allOf conditional
>> block that disallows clocks?
>>
> 
> No, we should not do that, it will conflict with the following up gpu smmu binding
> that fallbacks to "qcom,adreno-smmu" and requires clock.
> 
> Thanks,
> Jingyi
> 

Just found the commit "dt-bindings: arm-smmu: Constrain clocks for newer Qualcomm variants"
has added the block to disallow clks, will send a new patch to fix this.

Thanks,
Jingyi

>> When qcom,maili-smmu-500 is missing from the conditional block that matches
>> other similar platforms:
>>
>>    - if:
>>        properties:
>>          compatible:
>>            items:
>>              - enum:
>>                  - qcom,eliza-smmu-500
>>                  [ ... ]
>>                  - qcom,kaanapali-smmu-500
>>              - const: qcom,smmu-500
>>              - const: arm,mmu-500
>>      then:
>>        properties:
>>          clock-names: false
>>          clocks: false
>>
>> Device trees defining qcom,maili-smmu-500 that incorrectly include clocks
>> might silently pass schema validation during dt_binding_check.
>>
>>>                 - qcom,milos-smmu-500
>>>                 - qcom,nord-smmu-500
>>>                 - qcom,qcm2290-smmu-500
>>
>