Re: [PATCH v3 3/4] dt-bindings: iio: dac: add support for AD3532R/AD3532

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message for the refactoring patch claims to 'Switch spi_device_id to named initializers', but this change was never actually implemented in the code.
--

commit 2f85a102e878e53764e40f42a40c71a43b98d329
Author: Kim Seer Paller <kimseer.paller@analog.com>

dt-bindings: iio: dac: add support for AD3532R/AD3532

This commit adds support for the AD3532 and AD3532R 16-channel DACs.
It updates the device tree binding description and adds the corresponding
compatible strings for the new variants.

> dt-bindings: iio: dac: add support for AD3532R/AD3532
>
> The AD3532R/AD3532 is a 16-channel version of the AD3530R/AD3530.
> This adds compatible strings for the AD3532R/AD3532.

[Severity: Medium]
Are we missing the change to switch spi_device_id to named initializers?

The commit message for the refactoring patch claims to 'Switch spi_device_id
to named initializers', but this change was never actually implemented in the
code.

Looking at ad3530r_id in drivers/iio/dac/ad3530r.c, the array remains
populated with positional initializers with type casts:

static const struct spi_device_id ad3530r_id[] = {
	{ "ad3530", (kernel_ulong_t)&ad3530_chip },
	{ "ad3530r", (kernel_ulong_t)&ad3530r_chip },

Is there a missing patch in this series where the named initializers are
actually applied?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260629-iio-ad3532r-support-v3-0-f6e4f4abebbe@analog.com?part=3