Re: [PATCH v3 1/4] iio: dac: ad3530r: Refactor setup to table-driven register bank approach

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message claims to switch `spi_device_id` to named initializers, but this change is missing from the patch.
--

commit 54fc2d1026683255f5c87f5095c8f2ddef61fbf3
Author: Kim Seer Paller <kimseer.paller@analog.com>

iio: dac: ad3530r: Refactor setup to table-driven register bank approach

This commit replaces direct register calls in ad3530r_setup() with
per-chip register address arrays and bank helpers. It also converts
sw_ldac_trig_reg to a function pointer for per-bank LDAC trigger
register selection.

> Replace direct register calls in ad3530r_setup() with per-chip register
> address arrays and bank helpers (ad3530r_set_reg_bank_bits,
> ad3530r_write_reg_banks). Convert sw_ldac_trig_reg from a static
> register address to a function pointer for per-bank LDAC trigger
> register selection. Switch spi_device_id to named initializers.

[Severity: Medium]
Is this description accurate?

The commit message claims to switch spi_device_id to named initializers,
but this change is missing from the patch. Looking at ad3530r_id in
drivers/iio/dac/ad3530r.c, it still uses positional initializers:

static const struct spi_device_id ad3530r_id[] = {
	{ "ad3530", (kernel_ulong_t)&ad3530_chip },
	{ "ad3530r", (kernel_ulong_t)&ad3530r_chip },
	{ "ad3531", (kernel_ulong_t)&ad3531_chip },
	{ "ad3531r", (kernel_ulong_t)&ad3531r_chip },
	{ }
};

Was this change accidentally omitted from the patch, or should the commit
message be updated?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260629-iio-ad3532r-support-v3-0-f6e4f4abebbe@analog.com?part=1