Re: [PATCH v3 3/4] arm64: dts: qcom: sm8250: Add JPEG encoder node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] Renaming `interconnect-names` in the `camss` DT node violates the API contract and fatally breaks the `camss` driver probe on SM8250.
- [Low] The modifications to the `camss` node violate the `qcom,sm8250-camss.yaml` binding schema, resulting in DT validation failures.
--

commit 28e11fda34f9237ee15cc0f987e7147787f608e8
Author: Atanas Filipov <atanas.filipov@oss.qualcomm.com>

arm64: dts: qcom: sm8250: Add JPEG encoder node

Add the JPEG encoder hardware node to the SM8250 device tree so the
qcom-jpeg V4L2 encoder driver can bind and operate on this platform.

> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> index 7076720413ab2..d0cacb4ec35bb 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> @@ -4472,6 +4472,9 @@ cci1_i2c1: i2c-bus@1 {
>  		camss: camss@ac6a000 {
>  			compatible = "qcom,sm8250-camss";
>  			status = "disabled";
> +			#address-cells = <2>;
> +			#size-cells = <2>;
> +			ranges;

[Severity: Low]
Does adding these new properties and the jpeg-encoder child node cause device
tree validation failures?

The qcom,sm8250-camss.yaml schema uses additionalProperties: false and does
not appear to currently document these new properties or the child node. This
might cause make dtbs_check to complain about unapproved properties.

[ ... ]
> -			interconnect-names = "cam_ahb",
> -					     "cam_hf_0_mnoc",
> -					     "cam_sf_0_mnoc",
> -					     "cam_sf_icp_mnoc";
> +			interconnect-names = "ahb",
> +					     "hf_mnoc",
> +					     "sf_mnoc",
> +					     "icp_mnoc";

[Severity: High]
Will renaming these interconnect-names break the camera subsystem probe on
SM8250?

The camss driver expects the original names to be present. During boot,
camss_probe() calls camss_icc_get(), which searches for names hardcoded
in icc_res_sm8250:

drivers/media/platform/qcom/camss/camss.c:
static const struct resources_icc icc_res_sm8250[] = {
        { .name = "cam_ahb", },
        ...

If devm_of_icc_get() searches for "cam_ahb" but the device tree provides
"ahb", the lookup will return -EINVAL and cause the probe to abort.

Additionally, does renaming these properties violate the allowed items list
in qcom,sm8250-camss.yaml?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260629121750.3469292-1-atanas.filipov@oss.qualcomm.com?part=3