Re: [PATCH v3 2/4] dt-bindings: media: qcom: Add JPEG encoder binding

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Device tree schema validation failure: the example uses an incomplete and schema-violating parent `camss` node.
--

commit 862ed8809d046c435b4cc946e8aea64e3ff8a893
Author: Atanas Filipov <atanas.filipov@oss.qualcomm.com>

dt-bindings: media: qcom: Add JPEG encoder binding

This commit adds the device tree binding for the Qualcomm JPEG encoder
hardware block found on SM8250 SoCs. It defines the required properties,
clocks, and interconnects for the memory-to-memory standalone IP.

> diff --git a/Documentation/devicetree/bindings/media/qcom,jpeg-encoder.yaml b/Documentation/devicetree/bindings/media/qcom,jpeg-encoder.yaml
> new file mode 100644
> index 0000000000000..c8b4808054cb1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/qcom,jpeg-encoder.yaml
[ ... ]
> +examples:
> +  - |
[ ... ]
> +    soc {
> +        #address-cells = <2>;
> +        #size-cells = <2>;
> +
> +        camss@ac6a000 {
> +            compatible = "qcom,sm8250-camss";
> +            reg = <0 0x0ac6a000 0 0x2000>;
> +            #address-cells = <2>;
> +            #size-cells = <2>;
> +            ranges;
> +
> +            jpeg-encoder@ac53000 {

[Severity: Medium]
Will this example cause a schema validation failure during make dt_binding_check?

The parent node uses the "qcom,sm8250-camss" compatible string, which means
it will be validated against the existing camss schema. Since the camss
schema enforces additionalProperties: false and does not permit
#address-cells, #size-cells, ranges, or child nodes, the validation will fail.

The example node also appears to be missing other required properties for the
camss binding, such as clocks and interrupts.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260629121750.3469292-1-atanas.filipov@oss.qualcomm.com?part=2