Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Loic Poulain" <loic.poulain@oss.qualcomm.com>
Cc: conor+dt@kernel.org, robh@kernel.org, devicetree@vger.kernel.org,
	linux-leds@vger.kernel.org, lee@kernel.org
Subject: Re: [PATCH 2/3] leds: pca963x: add multicolor LED class support
Date: Mon, 29 Jun 2026 19:59:44 +0000	[thread overview]
Message-ID: <20260629195944.B594F1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260629-monza-leds-v1-2-0cf7c0a7dc14@oss.qualcomm.com>

> Allow grouping of individual PCA963x PWM channels into a single
> multicolor LED device by adding support for the LED multicolor class.
> 
> A child node with sub-children is treated as a multicolor group,
> others are treated as single leds, keeping full backwards compatibility.
> 
> Signed-off-by: Loic Poulain <loic.poulain@oss.qualcomm.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260629-monza-leds-v1-0-0cf7c0a7dc14@oss.qualcomm.com?part=2


  reply	other threads:[~2026-06-29 19:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-29 19:52 [PATCH 0/3] leds: pca963x: Add multicolor support and enable Monza RGB LEDs Loic Poulain
2026-06-29 19:52 ` [PATCH 1/3] dt-bindings: leds: nxp,pca963x: add multicolor LED support Loic Poulain
2026-06-29 19:58   ` sashiko-bot
2026-06-30  7:24   ` Krzysztof Kozlowski
2026-06-29 19:52 ` [PATCH 2/3] leds: pca963x: add multicolor LED class support Loic Poulain
2026-06-29 19:59   ` sashiko-bot [this message]
2026-06-29 19:52 ` [PATCH 3/3] arm64: dts: monaco-arduino-monza: microcontroller LEDs Loic Poulain
2026-06-29 19:58   ` sashiko-bot
2026-06-30  9:09   ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260629195944.B594F1F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=loic.poulain@oss.qualcomm.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox