Re: [PATCH 3/3] arm64: dts: monaco-arduino-monza: microcontroller LEDs

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Device tree unit addresses for `led@10` and `led@11` are incorrectly formatted in decimal instead of hexadecimal.
--

commit 21dc3bc44056192e48843a18f3858786db53ea22
Author: Loic Poulain <loic.poulain@oss.qualcomm.com>

arm64: dts: monaco-arduino-monza: microcontroller LEDs

This commit adds a led controller compatible with PCA9635 to the Monaco
Arduino Monza board. It configures four RGB LEDs controlled via channels
0-2, 3-5, 6-8, and 9-11.

> diff --git a/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts b/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts
> index 379b796f261f4..71685e54a3781 100644
> --- a/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts
> +++ b/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts

[ ... ]

> +		multi-led@3 {
> +			reg = <3>;
> +			label = "stm-led-4";
> +			color = <LED_COLOR_ID_RGB>;
> +			function = LED_FUNCTION_STATUS;
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +
> +			led@9 {
> +				reg = <9>;
> +				color = <LED_COLOR_ID_RED>;
> +			};
> +
> +			led@10 {
> +				reg = <10>;
> +				color = <LED_COLOR_ID_GREEN>;
> +			};
> +
> +			led@11 {

[Severity: Low]
This isn't a functional bug, but should the unit addresses for led@10 and led@11
be formatted as lowercase hexadecimal (e.g. led@a and led@b) to match their reg
properties and avoid dtc unit_address_format warnings?

> +				reg = <11>;
> +				color = <LED_COLOR_ID_BLUE>;
> +			};
> +		};
> +	};
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260629-monza-leds-v1-0-0cf7c0a7dc14@oss.qualcomm.com?part=3