From: Krzysztof Kozlowski <krzk@kernel.org>
To: Neo Chang <YLCHANG2@nuvoton.com>
Cc: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz,
robh@kernel.org, krzk+dt@kernel.org,
linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
alsa-devel@alsa-project.org, neo.chang70@gmail.com,
kchsu0@nuvoton.com, sjlin0@nuvoton.com
Subject: Re: [PATCH v5 1/2] ASoC: dt-bindings: nuvoton,nau8360: Add NAU83G60
Date: Tue, 30 Jun 2026 08:40:08 +0200 [thread overview]
Message-ID: <20260630-amusing-striped-urchin-d49c93@quoll> (raw)
In-Reply-To: <20260630021510.821919-2-YLCHANG2@nuvoton.com>
On Tue, Jun 30, 2026 at 10:15:09AM +0800, Neo Chang wrote:
> + clocks:
> + maxItems: 1
> +
> + clock-names:
> + const: mclk
> +
> + firmware-name:
> + items:
> + - description: |
Drop |
> + Left DSP core firmware.
> + In PBTL mode, the Left firmware is ignored and only the Right is applied.
> + - description: Right DSP core firmware.
> +
> + nuvoton,pbtl-enable:
> + type: boolean
> + description: NAU83G60 supports PBTL mode for mono output.
> +
> + nuvoton,dac-cur-enable:
> + type: boolean
> + description: |
Drop |
There is no formartting to preserve and I did not ask to introduce it
here. I commented in completely different place.
With these two fixed:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-06-30 6:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-30 2:15 [PATCH v5 0/2] ASoC: codecs: Add Nuvoton NAU83G60 audio codec driver Neo Chang
2026-06-30 2:15 ` [PATCH v5 1/2] ASoC: dt-bindings: nuvoton,nau8360: Add NAU83G60 Neo Chang
2026-06-30 6:40 ` Krzysztof Kozlowski [this message]
2026-07-03 3:19 ` YLCHANG2
2026-06-30 2:15 ` [PATCH v5 2/2] ASoC: codecs: nau8360: Add support for NAU83G60 amplifier Neo Chang
2026-06-30 2:35 ` sashiko-bot
2026-07-02 15:15 ` Mark Brown
2026-07-03 3:26 ` YLCHANG2
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260630-amusing-striped-urchin-d49c93@quoll \
--to=krzk@kernel.org \
--cc=YLCHANG2@nuvoton.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kchsu0@nuvoton.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=neo.chang70@gmail.com \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=sjlin0@nuvoton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox