Devicetree
 help / color / mirror / Atom feed
From: YLCHANG2 <neo.chang70@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Neo Chang <YLCHANG2@nuvoton.com>,
	lgirdwood@gmail.com, perex@perex.cz, robh@kernel.org,
	krzk+dt@kernel.org, linux-sound@vger.kernel.org,
	devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
	kchsu0@nuvoton.com, sjlin0@nuvoton.com
Subject: Re: [PATCH v5 2/2] ASoC: codecs: nau8360: Add support for NAU83G60 amplifier
Date: Mon, 6 Jul 2026 11:23:15 +0800	[thread overview]
Message-ID: <61a878fd-1e49-2403-9e63-66544d17861d@gmail.com> (raw)
In-Reply-To: <akpOy2HJsDCu7wVx@sirena.co.uk>


On 7/5/26 20:32, Mark Brown wrote:
> On Fri, Jul 03, 2026 at 11:26:12AM +0800, YLCHANG2 wrote:
>> On 7/2/26 23:15, Mark Brown wrote:
>>> I would expect TDM to be configured by set_tdm_slot() from the machine
>>> driver, not from userspace.  I see the driver does actually have a
>>> set_tdm_slot() operation...
>> Our DSP functions require specific Slot mapping (e.g., Slot 0 for AECL, Slot
>> 1 for AECR).
>> The standard set_tdm_slot() only defines active slots but doesn't handle the
>> functional mapping.
>> We originally intended to allow dynamic mapping via UCM/userspacea and then
>> apply these settings using set_tdm_slot().
>> How should we implement this mapping according to ASoC standards?
> This would usually be doing using DAPM routing if it's expected to be
> runtime variable, define AIF widgets for the bus slots then route to
> them.
>
>> Should we define the default mapping during the codec probe stage,
>> or is there a preferred way to handle this via the machine driver?
> Device properties, this is better if it's supposed to be fixed for the
> system.
Hi Mark,

Thank you for the suggestion.
We will drop the dynamic mapping via kcontrols.
Instead, we will adopt a static approach using device tree properties.

In the next patch version, we plan to:
1. Remove the SOC_ENUM kcontrols intended for DSP functional slot mapping.
2. Introduce device tree properties (e.g., nuvoton,dsp-tx-slot-mapping 
and nuvoton,dsp-rx-slot-mapping).
3. Parse these properties during the codec probe stage to configure the 
internal DSP TDM special function and path registers statically.


      reply	other threads:[~2026-07-06  3:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-30  2:15 [PATCH v5 0/2] ASoC: codecs: Add Nuvoton NAU83G60 audio codec driver Neo Chang
2026-06-30  2:15 ` [PATCH v5 1/2] ASoC: dt-bindings: nuvoton,nau8360: Add NAU83G60 Neo Chang
2026-06-30  6:40   ` Krzysztof Kozlowski
2026-07-03  3:19     ` YLCHANG2
2026-06-30  2:15 ` [PATCH v5 2/2] ASoC: codecs: nau8360: Add support for NAU83G60 amplifier Neo Chang
2026-06-30  2:35   ` sashiko-bot
2026-07-02 15:15   ` Mark Brown
2026-07-03  3:26     ` YLCHANG2
2026-07-05 12:32       ` Mark Brown
2026-07-06  3:23         ` YLCHANG2 [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=61a878fd-1e49-2403-9e63-66544d17861d@gmail.com \
    --to=neo.chang70@gmail.com \
    --cc=YLCHANG2@nuvoton.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kchsu0@nuvoton.com \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=robh@kernel.org \
    --cc=sjlin0@nuvoton.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox