Re: [PATCH net-next v6 14/15] dt-bindings: net: add onsemi's S2500

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The device tree binding example intentionally encodes a software framework bug workaround instead of accurately describing the hardware interrupt trigger type.
--

commit 4f05643415ec5654a4ffe32ab4202c0990bc3930
Author: Selvamani Rajagopal <Selvamani.Rajagopal@onsemi.com>

dt-bindings: net: add onsemi's S2500

This commit adds a YAML device tree binding for the onsemi S2500 IEEE
802.3cg compliant Ethernet transceiver. It explicitly uses a falling edge
interrupt trigger in the binding example to work around a current bug in
the OA TC6 framework code, rather than specifying the true hardware value.

> diff --git a/Documentation/devicetree/bindings/net/onnn,s2500.yaml b/Documentation/devicetree/bindings/net/onnn,s2500.yaml
> new file mode 100644
> index 0000000000000..11edf10508d9f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/onnn,s2500.yaml
[ ... ]
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    spi {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      ethernet@0 {
> +        compatible = "onnn,s2500";
> +        reg = <0>;
> +        pinctrl-names = "default";
> +        pinctrl-0 = <&eth0_pins>;
> +        interrupt-parent = <&gpio>;
> +        interrupts = <25 IRQ_TYPE_EDGE_FALLING>;

[Severity: Medium]
Is it appropriate to encode a software bug workaround into a device tree
binding example?

The commit message notes that the OPEN Alliance 10BASE-T1x specification
dictates an active-low level interrupt, but IRQ_TYPE_EDGE_FALLING is used
here to accommodate an existing bug in the Linux OA TC6 framework. 

Because device tree bindings act as a stable, OS-agnostic description of
physical hardware, will publishing this example encourage board developers
to copy a faulty configuration into production device trees?

Could this lead to ABI compatibility breaks and missed interrupts once the
underlying Linux framework bug is fixed, as the device trees would then
be providing an invalid hardware description to the operating system?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260629-s2500-mac-phy-support-v6-0-18ce79500371@onsemi.com?part=14