Re: [PATCH net-next v6 03/15] net: ethernet: oa_tc6: Move oa_tc6.c to its own directory

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [Medium] Kernel module rename from `oa_tc6.ko` to `oa_tc6_mod.ko` breaks ABI.
- [Low] Unintended removal of the 'if COMPILE_TEST' condition from the Kconfig prompt.
- [Low] MAINTAINERS entry update uses a restrictive wildcard pattern that orphans the directory's Makefile and Kconfig.
--

commit 17abade4ed4c6f154b7b7813c44e60fe8fc7040d
Author: Selvamani Rajagopal <Selvamani.Rajagopal@onsemi.com>

net: ethernet: oa_tc6: Move oa_tc6.c to its own directory

This commit moves oa_tc6.c to a new drivers/net/ethernet/oa_tc6 directory.
It updates Kconfig, Makefile, and MAINTAINERS to support adding future files
for hardware timestamp and PTP related APIs.

> diff --git a/MAINTAINERS b/MAINTAINERS
> index 15011f5752a99..ff1295d37ae21 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -20217,7 +20217,7 @@ M:	Parthiban Veerasooran <parthiban.veerasooran@microchip.com>
>  L:	netdev@vger.kernel.org
>  S:	Maintained
>  F:	Documentation/networking/oa-tc6-framework.rst
> -F:	drivers/net/ethernet/oa_tc6.c
> +F:	drivers/net/ethernet/oa_tc6/oa_tc6*

[Severity: Low]
Does this restrictive wildcard pattern orphan the new Makefile and Kconfig
files?

Since it only matches files starting with oa_tc6, patches modifying those
build files might not automatically CC the maintainers via get_maintainer.pl.

[ ... ]

> diff --git a/drivers/net/ethernet/oa_tc6/Kconfig b/drivers/net/ethernet/oa_tc6/Kconfig
> new file mode 100644
> index 0000000000000..97345f345fb9f
> --- /dev/null
> +++ b/drivers/net/ethernet/oa_tc6/Kconfig
> @@ -0,0 +1,16 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +#
> +# OA TC6 10BASE-T1x MAC-PHY configuration
> +#
> +
> +config OA_TC6
> +	tristate "OPEN Alliance TC6 10BASE-T1x MAC-PHY support"

[Severity: Low]
Was it intentional to drop the if COMPILE_TEST condition from the tristate
prompt here?

The original config in drivers/net/ethernet/Kconfig had 
tristate "..." if COMPILE_TEST, which kept the prompt hidden unless
COMPILE_TEST was enabled. Dropping it exposes the prompt to any user with
SPI enabled.

> +	depends on SPI
> +	select PHYLIB

[ ... ]

> diff --git a/drivers/net/ethernet/oa_tc6/Makefile b/drivers/net/ethernet/oa_tc6/Makefile
> new file mode 100644
> index 0000000000000..f24aae852ef27
> --- /dev/null
> +++ b/drivers/net/ethernet/oa_tc6/Makefile
> @@ -0,0 +1,7 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +#
> +# Makefile for OA TC6 10BASE-T1x MAC-PHY
> +#
> +
> +obj-$(CONFIG_OA_TC6) := oa_tc6_mod.o
> +oa_tc6_mod-objs := oa_tc6.o

[Severity: Medium]
Does this change break userspace ABI by implicitly renaming the compiled
module from oa_tc6.ko to oa_tc6_mod.ko?

Modifying the module name can break external scripts, modprobe configurations,
and initramfs expectations that rely on the old name.

To fix Kbuild circular dependency warnings while keeping the original module
name, should the C file be renamed instead (e.g., to oa_tc6_core.c) while
keeping obj-$(CONFIG_OA_TC6) += oa_tc6.o?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260629-s2500-mac-phy-support-v6-0-18ce79500371@onsemi.com?part=3