Re: [PATCH v5 2/3] dt-bindings: iio: dac: Add AD5529R

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1756 bytes --]

On Wed, Jul 01, 2026 at 08:40:40AM +0200, Janani Sunil wrote:

> +patternProperties:
> +  "^channel@([0-9a-f]{1,2})$":
> +    type: object
> +    description: Child nodes for individual channel configuration
> +
> +    properties:
> +      reg:
> +        description: Channel number.
> +        minimum: 0
> +        maximum: 63
> +
> +      spi,device-addr:
> +        $ref: /schemas/types.yaml#/definitions/uint32

Same comments apply here about whether this is a channel or a spi
peripheral level property.

> +        enum: [0, 1, 2, 3]
> +        description:
> +          Device address selected by the ID0 and ID1 pins. Up to four AD5529R
> +          devices can share a single SPI chip select; each device responds only
> +          to transfers whose address bits [13:12] match its configured address.
> +
> +      adi,output-range-microvolt:

I didn't notice this on the previous versions, but doesn't this
duplicate the common output-range-microvolt in dac.yaml, which you
should be including here because these channels are dacs?

pw-bot: changes-requested

Cheers,
Conor.

> +        description: |
> +          Output voltage range for this channel as [min, max] in microvolts.
> +          If not specified, defaults to 0V to 5V range.
> +        oneOf:
> +          - items:
> +              - const: 0
> +              - enum: [5000000, 10000000, 20000000, 40000000]
> +          - items:
> +              - const: -5000000
> +              - const: 5000000
> +          - items:
> +              - const: -10000000
> +              - const: 10000000
> +          - items:
> +              - const: -15000000
> +              - const: 15000000
> +          - items:
> +              - const: -20000000
> +              - const: 20000000

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]